Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/arch/xen/x86 stipending(): if we're going to process som...



details:   https://anonhg.NetBSD.org/src/rev/bc537dacd253
branches:  trunk
changeset: 366580:bc537dacd253
user:      bouyer <bouyer%NetBSD.org@localhost>
date:      Tue May 31 12:52:59 2022 +0000

description:
stipending(): if we're going to process some interrupts don't return 0.
Hopefully fixes random hang seen in i386 Xen PV.

The bug has been there ~forever but was masked by the fact that spllower()
did call event handlers much more often.

diffstat:

 sys/arch/xen/x86/hypervisor_machdep.c |  5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diffs (26 lines):

diff -r 064a0b8f659d -r bc537dacd253 sys/arch/xen/x86/hypervisor_machdep.c
--- a/sys/arch/xen/x86/hypervisor_machdep.c     Tue May 31 11:22:33 2022 +0000
+++ b/sys/arch/xen/x86/hypervisor_machdep.c     Tue May 31 12:52:59 2022 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: hypervisor_machdep.c,v 1.40 2022/05/19 09:54:27 bouyer Exp $   */
+/*     $NetBSD: hypervisor_machdep.c,v 1.41 2022/05/31 12:52:59 bouyer Exp $   */
 
 /*
  *
@@ -54,7 +54,7 @@
 
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: hypervisor_machdep.c,v 1.40 2022/05/19 09:54:27 bouyer Exp $");
+__KERNEL_RCSID(0, "$NetBSD: hypervisor_machdep.c,v 1.41 2022/05/31 12:52:59 bouyer Exp $");
 
 #include <sys/param.h>
 #include <sys/systm.h>
@@ -208,6 +208,7 @@
         */
 
        while (vci->evtchn_upcall_pending) {
+               ret = 1;
                x86_disable_intr();
 
                vci->evtchn_upcall_pending = 0;



Home | Main Index | Thread Index | Old Index