Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/dev cgd(4): Remove recently added dependency on adiantum.



details:   https://anonhg.NetBSD.org/src/rev/b7bb7ba20655
branches:  trunk
changeset: 364617:b7bb7ba20655
user:      riastradh <riastradh%NetBSD.org@localhost>
date:      Fri Apr 01 00:21:19 2022 +0000

description:
cgd(4): Remove recently added dependency on adiantum.

While this dependency is technically correct, it triggers a problem
with module initialization for builtin modules that manifests as an
instant crash on boot for x86 (and likely arm) kernels, and that
problem is not trivial to solve immediately.  See the top of
sys/crypto/aes/aes_impl.c for a summary of the problem and why it's
tricky.

So as a stop-gap measure, we'll remove this dependency for now; we
can reinstate it later once the underlying problem with module
initialization order is resolved.

Reported-by: syzbot+e9b3550af985b6557414%syzkaller.appspotmail.com@localhost
(actually first reported, to my knowledge, by pgoyette@, but this
line tells syzkaller that we fixed the problem)

diffstat:

 sys/dev/cgd.c |  6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diffs (27 lines):

diff -r 542b5503280f -r b7bb7ba20655 sys/dev/cgd.c
--- a/sys/dev/cgd.c     Fri Apr 01 00:16:40 2022 +0000
+++ b/sys/dev/cgd.c     Fri Apr 01 00:21:19 2022 +0000
@@ -1,4 +1,4 @@
-/* $NetBSD: cgd.c,v 1.143 2022/03/31 19:30:15 pgoyette Exp $ */
+/* $NetBSD: cgd.c,v 1.144 2022/04/01 00:21:19 riastradh Exp $ */
 
 /*-
  * Copyright (c) 2002 The NetBSD Foundation, Inc.
@@ -30,7 +30,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: cgd.c,v 1.143 2022/03/31 19:30:15 pgoyette Exp $");
+__KERNEL_RCSID(0, "$NetBSD: cgd.c,v 1.144 2022/04/01 00:21:19 riastradh Exp $");
 
 #include <sys/types.h>
 #include <sys/param.h>
@@ -1723,7 +1723,7 @@
        aprint_debug("cgd: self-tests passed\n");
 }
 
-MODULE(MODULE_CLASS_DRIVER, cgd, "adiantum,blowfish,des,dk_subr,bufq_fcfs");
+MODULE(MODULE_CLASS_DRIVER, cgd, "blowfish,des,dk_subr,bufq_fcfs");
 
 #ifdef _MODULE
 CFDRIVER_DECL(cgd, DV_DISK, NULL);



Home | Main Index | Thread Index | Old Index