[src/trunk]: src/sys/dev/pci Use xc_barrier to wait for finish of the interru...

[yamaguchi <yamaguchi%NetBSD.org@localhost>]

details:   https://anonhg.NetBSD.org/src/rev/d23cc0e404c0
branches:  trunk
changeset: 364611:d23cc0e404c0
user:      yamaguchi <yamaguchi%NetBSD.org@localhost>
date:      Thu Mar 31 06:21:41 2022 +0000

description:
Use xc_barrier to wait for finish of the interrupt handler

poited out by riastradh@n.o, thanks.

diffstat:

 sys/dev/pci/if_ixl.c |  18 ++++++++++++------
 1 files changed, 12 insertions(+), 6 deletions(-)

diffs (57 lines):

diff -r 48f897aae866 -r d23cc0e404c0 sys/dev/pci/if_ixl.c
--- a/sys/dev/pci/if_ixl.c      Thu Mar 31 06:20:14 2022 +0000
+++ b/sys/dev/pci/if_ixl.c      Thu Mar 31 06:21:41 2022 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: if_ixl.c,v 1.80 2022/03/31 06:20:14 yamaguchi Exp $    */
+/*     $NetBSD: if_ixl.c,v 1.81 2022/03/31 06:21:41 yamaguchi Exp $    */
 
 /*
  * Copyright (c) 2013-2015, Intel Corporation
@@ -74,7 +74,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: if_ixl.c,v 1.80 2022/03/31 06:20:14 yamaguchi Exp $");
+__KERNEL_RCSID(0, "$NetBSD: if_ixl.c,v 1.81 2022/03/31 06:21:41 yamaguchi Exp $");
 
 #ifdef _KERNEL_OPT
 #include "opt_net_mpsafe.h"
@@ -95,6 +95,7 @@
 #include <sys/pcq.h>
 #include <sys/syslog.h>
 #include <sys/workqueue.h>
+#include <sys/xcall.h>
 
 #include <sys/bus.h>
 
@@ -989,6 +990,14 @@
        return NULL;
 }
 
+static void
+ixl_intr_barrier(void)
+{
+
+       /* wait for finish of all handler */
+       xc_barrier(0);
+}
+
 static int
 ixl_match(device_t parent, cfdata_t match, void *aux)
 {
@@ -1447,14 +1456,11 @@
        ixl_stop(ifp, 1);
 
        ixl_disable_other_intr(sc);
+       ixl_intr_barrier();
 
        callout_halt(&sc->sc_stats_callout, NULL);
        ixl_work_wait(sc->sc_workq, &sc->sc_stats_task);
 
-       /* wait for ATQ handler */
-       mutex_enter(&sc->sc_atq_lock);
-       mutex_exit(&sc->sc_atq_lock);
-
        ixl_work_wait(sc->sc_workq, &sc->sc_arq_task);
        ixl_work_wait(sc->sc_workq, &sc->sc_link_state_task);