[src/trunk]: src/sys/dev/usb usbnet drivers: Omit redundant device reset via ...

[riastradh <riastradh%NetBSD.org@localhost>]

details:   https://anonhg.NetBSD.org/src/rev/aacff5bb462e
branches:  trunk
changeset: 362547:aacff5bb462e
user:      riastradh <riastradh%NetBSD.org@localhost>
date:      Thu Mar 03 05:55:38 2022 +0000

description:
usbnet drivers: Omit redundant device reset via *_uno_stop on init.

Only those drivers where *_uno_stop is just *_reset, and *_uno_init
immediately calls *_reset afterward, are affected.

diffstat:

 sys/dev/usb/if_axe.c  |  7 ++-----
 sys/dev/usb/if_mos.c  |  7 ++-----
 sys/dev/usb/if_smsc.c |  7 ++-----
 3 files changed, 6 insertions(+), 15 deletions(-)

diffs (84 lines):

diff -r 537e4655ae65 -r aacff5bb462e sys/dev/usb/if_axe.c
--- a/sys/dev/usb/if_axe.c      Thu Mar 03 05:55:29 2022 +0000
+++ b/sys/dev/usb/if_axe.c      Thu Mar 03 05:55:38 2022 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: if_axe.c,v 1.147 2022/03/03 05:55:29 riastradh Exp $   */
+/*     $NetBSD: if_axe.c,v 1.148 2022/03/03 05:55:38 riastradh Exp $   */
 /*     $OpenBSD: if_axe.c,v 1.137 2016/04/13 11:03:37 mpi Exp $ */
 
 /*
@@ -87,7 +87,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: if_axe.c,v 1.147 2022/03/03 05:55:29 riastradh Exp $");
+__KERNEL_RCSID(0, "$NetBSD: if_axe.c,v 1.148 2022/03/03 05:55:38 riastradh Exp $");
 
 #ifdef _KERNEL_OPT
 #include "opt_usb.h"
@@ -1211,9 +1211,6 @@
        struct axe_softc * const sc = usbnet_softc(un);
        int rxmode;
 
-       /* Cancel pending I/O */
-       axe_uno_stop(ifp, 1);
-
        /* Reset the ethernet interface. */
        axe_reset(un);
 
diff -r 537e4655ae65 -r aacff5bb462e sys/dev/usb/if_mos.c
--- a/sys/dev/usb/if_mos.c      Thu Mar 03 05:55:29 2022 +0000
+++ b/sys/dev/usb/if_mos.c      Thu Mar 03 05:55:38 2022 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: if_mos.c,v 1.19 2022/03/03 05:55:29 riastradh Exp $    */
+/*     $NetBSD: if_mos.c,v 1.20 2022/03/03 05:55:38 riastradh Exp $    */
 /*     $OpenBSD: if_mos.c,v 1.40 2019/07/07 06:40:10 kevlo Exp $       */
 
 /*
@@ -72,7 +72,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: if_mos.c,v 1.19 2022/03/03 05:55:29 riastradh Exp $");
+__KERNEL_RCSID(0, "$NetBSD: if_mos.c,v 1.20 2022/03/03 05:55:38 riastradh Exp $");
 
 #include <sys/param.h>
 
@@ -732,9 +732,6 @@
        u_int8_t                rxmode;
        unsigned char           ipgs[2];
 
-       /* Cancel pending I/O */
-       mos_uno_stop(ifp, 1);
-
        /* Reset the ethernet interface. */
        mos_reset(un);
 
diff -r 537e4655ae65 -r aacff5bb462e sys/dev/usb/if_smsc.c
--- a/sys/dev/usb/if_smsc.c     Thu Mar 03 05:55:29 2022 +0000
+++ b/sys/dev/usb/if_smsc.c     Thu Mar 03 05:55:38 2022 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: if_smsc.c,v 1.89 2022/03/03 05:55:29 riastradh Exp $   */
+/*     $NetBSD: if_smsc.c,v 1.90 2022/03/03 05:55:38 riastradh Exp $   */
 
 /*     $OpenBSD: if_smsc.c,v 1.4 2012/09/27 12:38:11 jsg Exp $ */
 /*     $FreeBSD: src/sys/dev/usb/net/if_smsc.c,v 1.1 2012/08/15 04:03:55 gonzo Exp $ */
@@ -61,7 +61,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: if_smsc.c,v 1.89 2022/03/03 05:55:29 riastradh Exp $");
+__KERNEL_RCSID(0, "$NetBSD: if_smsc.c,v 1.90 2022/03/03 05:55:38 riastradh Exp $");
 
 #ifdef _KERNEL_OPT
 #include "opt_usb.h"
@@ -555,9 +555,6 @@
        struct usbnet * const un = ifp->if_softc;
        struct smsc_softc * const sc = usbnet_softc(un);
 
-       /* Cancel pending I/O */
-       smsc_uno_stop(ifp, 1);
-
        /* Reset the ethernet interface. */
        smsc_reset(sc);