[src/trunk]: src/sys/dev/usb usbnet drivers: Omit redundant multicast filter ...

To: source-changes-hg%NetBSD.org@localhost
Subject: [src/trunk]: src/sys/dev/usb usbnet drivers: Omit redundant multicast filter ...
From: riastradh <riastradh%NetBSD.org@localhost>
Date: Thu, 03 Mar 2022 08:48:38 +0000
details:   https://anonhg.NetBSD.org/src/rev/58aae5da573a
branches:  trunk
changeset: 362532:58aae5da573a
user:      riastradh <riastradh%NetBSD.org@localhost>
date:      Thu Mar 03 05:53:33 2022 +0000

description:
usbnet drivers: Omit redundant multicast filter update on init.

diffstat:

 sys/dev/usb/if_aue.c  |  7 ++-----
 sys/dev/usb/if_axe.c  |  7 ++-----
 sys/dev/usb/if_axen.c |  7 ++-----
 sys/dev/usb/if_cue.c  |  7 ++-----
 sys/dev/usb/if_kue.c  |  7 ++-----
 sys/dev/usb/if_mos.c  |  7 ++-----
 sys/dev/usb/if_mue.c  |  7 ++-----
 sys/dev/usb/if_smsc.c |  7 ++-----
 sys/dev/usb/if_udav.c |  7 ++-----
 sys/dev/usb/if_ure.c  |  7 ++-----
 sys/dev/usb/if_url.c  |  7 ++-----
 11 files changed, 22 insertions(+), 55 deletions(-)

diffs (truncated from 308 to 300 lines):

diff -r dbe3ef6cf09f -r 58aae5da573a sys/dev/usb/if_aue.c
--- a/sys/dev/usb/if_aue.c      Thu Mar 03 05:53:23 2022 +0000
+++ b/sys/dev/usb/if_aue.c      Thu Mar 03 05:53:33 2022 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: if_aue.c,v 1.181 2022/03/03 05:53:23 riastradh Exp $   */
+/*     $NetBSD: if_aue.c,v 1.182 2022/03/03 05:53:33 riastradh Exp $   */
 
 /*
  * Copyright (c) 1997, 1998, 1999, 2000
@@ -76,7 +76,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: if_aue.c,v 1.181 2022/03/03 05:53:23 riastradh Exp $");
+__KERNEL_RCSID(0, "$NetBSD: if_aue.c,v 1.182 2022/03/03 05:53:33 riastradh Exp $");
 
 #ifdef _KERNEL_OPT
 #include "opt_usb.h"
@@ -977,9 +977,6 @@
 
        rv = usbnet_init_rx_tx(un);
 
-       /* Load the multicast filter. */
-       aue_uno_mcast(ifp);
-
        /* Enable RX and TX */
        aue_csr_write_1(sc, AUE_CTL0, AUE_CTL0_RXSTAT_APPEND | AUE_CTL0_RX_ENB);
        AUE_SETBIT(sc, AUE_CTL0, AUE_CTL0_TX_ENB);
diff -r dbe3ef6cf09f -r 58aae5da573a sys/dev/usb/if_axe.c
--- a/sys/dev/usb/if_axe.c      Thu Mar 03 05:53:23 2022 +0000
+++ b/sys/dev/usb/if_axe.c      Thu Mar 03 05:53:33 2022 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: if_axe.c,v 1.142 2022/03/03 05:53:23 riastradh Exp $   */
+/*     $NetBSD: if_axe.c,v 1.143 2022/03/03 05:53:33 riastradh Exp $   */
 /*     $OpenBSD: if_axe.c,v 1.137 2016/04/13 11:03:37 mpi Exp $ */
 
 /*
@@ -87,7 +87,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: if_axe.c,v 1.142 2022/03/03 05:53:23 riastradh Exp $");
+__KERNEL_RCSID(0, "$NetBSD: if_axe.c,v 1.143 2022/03/03 05:53:33 riastradh Exp $");
 
 #ifdef _KERNEL_OPT
 #include "opt_usb.h"
@@ -1298,9 +1298,6 @@
 
        axe_cmd(sc, AXE_CMD_RXCTL_WRITE, 0, rxmode, NULL);
 
-       /* Accept multicast frame or run promisc. mode */
-       axe_uno_mcast(ifp);
-
        return usbnet_init_rx_tx(un);
 }
 
diff -r dbe3ef6cf09f -r 58aae5da573a sys/dev/usb/if_axen.c
--- a/sys/dev/usb/if_axen.c     Thu Mar 03 05:53:23 2022 +0000
+++ b/sys/dev/usb/if_axen.c     Thu Mar 03 05:53:33 2022 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: if_axen.c,v 1.84 2022/03/03 05:53:23 riastradh Exp $   */
+/*     $NetBSD: if_axen.c,v 1.85 2022/03/03 05:53:33 riastradh Exp $   */
 /*     $OpenBSD: if_axen.c,v 1.3 2013/10/21 10:10:22 yuo Exp $ */
 
 /*
@@ -23,7 +23,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: if_axen.c,v 1.84 2022/03/03 05:53:23 riastradh Exp $");
+__KERNEL_RCSID(0, "$NetBSD: if_axen.c,v 1.85 2022/03/03 05:53:33 riastradh Exp $");
 
 #ifdef _KERNEL_OPT
 #include "opt_usb.h"
@@ -903,9 +903,6 @@
        /* Configure offloading engine. */
        axen_setoe_locked(un);
 
-       /* Program promiscuous mode and multicast filters. */
-       axen_uno_mcast(ifp);
-
        /* Enable receiver, set RX mode */
        axen_cmd(un, AXEN_CMD_MAC_READ2, 2, AXEN_MAC_RXCTL, &wval);
        rxmode = le16toh(wval);
diff -r dbe3ef6cf09f -r 58aae5da573a sys/dev/usb/if_cue.c
--- a/sys/dev/usb/if_cue.c      Thu Mar 03 05:53:23 2022 +0000
+++ b/sys/dev/usb/if_cue.c      Thu Mar 03 05:53:33 2022 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: if_cue.c,v 1.100 2022/03/03 05:53:14 riastradh Exp $   */
+/*     $NetBSD: if_cue.c,v 1.101 2022/03/03 05:53:33 riastradh Exp $   */
 
 /*
  * Copyright (c) 1997, 1998, 1999, 2000
@@ -57,7 +57,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: if_cue.c,v 1.100 2022/03/03 05:53:14 riastradh Exp $");
+__KERNEL_RCSID(0, "$NetBSD: if_cue.c,v 1.101 2022/03/03 05:53:33 riastradh Exp $");
 
 #ifdef _KERNEL_OPT
 #include "opt_inet.h"
@@ -647,9 +647,6 @@
                ctl |= CUE_ETHCTL_PROMISC;
        cue_csr_write_1(un, CUE_ETHCTL, ctl);
 
-       /* Load the multicast filter. */
-       cue_uno_mcast(ifp);
-
        /*
         * Set the number of RX and TX buffers that we want
         * to reserve inside the ASIC.
diff -r dbe3ef6cf09f -r 58aae5da573a sys/dev/usb/if_kue.c
--- a/sys/dev/usb/if_kue.c      Thu Mar 03 05:53:23 2022 +0000
+++ b/sys/dev/usb/if_kue.c      Thu Mar 03 05:53:33 2022 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: if_kue.c,v 1.113 2022/03/03 05:53:14 riastradh Exp $   */
+/*     $NetBSD: if_kue.c,v 1.114 2022/03/03 05:53:33 riastradh Exp $   */
 
 /*
  * Copyright (c) 1997, 1998, 1999, 2000
@@ -71,7 +71,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: if_kue.c,v 1.113 2022/03/03 05:53:14 riastradh Exp $");
+__KERNEL_RCSID(0, "$NetBSD: if_kue.c,v 1.114 2022/03/03 05:53:33 riastradh Exp $");
 
 #ifdef _KERNEL_OPT
 #include "opt_inet.h"
@@ -621,9 +621,6 @@
 #endif
        kue_setword(un, KUE_CMD_SET_URB_SIZE, 64);
 
-       /* Load the multicast filter. */
-       kue_uno_mcast(ifp);
-
        return usbnet_init_rx_tx(un);
 }
 
diff -r dbe3ef6cf09f -r 58aae5da573a sys/dev/usb/if_mos.c
--- a/sys/dev/usb/if_mos.c      Thu Mar 03 05:53:23 2022 +0000
+++ b/sys/dev/usb/if_mos.c      Thu Mar 03 05:53:33 2022 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: if_mos.c,v 1.15 2022/03/03 05:53:04 riastradh Exp $    */
+/*     $NetBSD: if_mos.c,v 1.16 2022/03/03 05:53:33 riastradh Exp $    */
 /*     $OpenBSD: if_mos.c,v 1.40 2019/07/07 06:40:10 kevlo Exp $       */
 
 /*
@@ -72,7 +72,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: if_mos.c,v 1.15 2022/03/03 05:53:04 riastradh Exp $");
+__KERNEL_RCSID(0, "$NetBSD: if_mos.c,v 1.16 2022/03/03 05:53:33 riastradh Exp $");
 
 #include <sys/param.h>
 
@@ -747,9 +747,6 @@
        mos_reg_write_1(un, MOS_IPG0, ipgs[0]);
        mos_reg_write_1(un, MOS_IPG1, ipgs[1]);
 
-       /* Accept multicast frame or run promisc. mode */
-       mos_uno_mcast(ifp);
-
        /* Enable receiver and transmitter, bridge controls speed/duplex mode */
        rxmode = mos_reg_read_1(un, MOS_CTL);
        rxmode |= MOS_CTL_RX_ENB | MOS_CTL_TX_ENB | MOS_CTL_BS_ENB;
diff -r dbe3ef6cf09f -r 58aae5da573a sys/dev/usb/if_mue.c
--- a/sys/dev/usb/if_mue.c      Thu Mar 03 05:53:23 2022 +0000
+++ b/sys/dev/usb/if_mue.c      Thu Mar 03 05:53:33 2022 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: if_mue.c,v 1.73 2022/03/03 05:53:14 riastradh Exp $    */
+/*     $NetBSD: if_mue.c,v 1.74 2022/03/03 05:53:33 riastradh Exp $    */
 /*     $OpenBSD: if_mue.c,v 1.3 2018/08/04 16:42:46 jsg Exp $  */
 
 /*
@@ -20,7 +20,7 @@
 /* Driver for Microchip LAN7500/LAN7800 chipsets. */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: if_mue.c,v 1.73 2022/03/03 05:53:14 riastradh Exp $");
+__KERNEL_RCSID(0, "$NetBSD: if_mue.c,v 1.74 2022/03/03 05:53:33 riastradh Exp $");
 
 #ifdef _KERNEL_OPT
 #include "opt_usb.h"
@@ -1239,9 +1239,6 @@
        /* Set MAC address. */
        mue_set_macaddr(un);
 
-       /* Load the multicast filter. */
-       mue_uno_mcast(ifp);
-
        /* TCP/UDP checksum offload engines. */
        mue_sethwcsum_locked(un);
 
diff -r dbe3ef6cf09f -r 58aae5da573a sys/dev/usb/if_smsc.c
--- a/sys/dev/usb/if_smsc.c     Thu Mar 03 05:53:23 2022 +0000
+++ b/sys/dev/usb/if_smsc.c     Thu Mar 03 05:53:33 2022 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: if_smsc.c,v 1.83 2022/03/03 05:53:23 riastradh Exp $   */
+/*     $NetBSD: if_smsc.c,v 1.84 2022/03/03 05:53:33 riastradh Exp $   */
 
 /*     $OpenBSD: if_smsc.c,v 1.4 2012/09/27 12:38:11 jsg Exp $ */
 /*     $FreeBSD: src/sys/dev/usb/net/if_smsc.c,v 1.1 2012/08/15 04:03:55 gonzo Exp $ */
@@ -61,7 +61,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: if_smsc.c,v 1.83 2022/03/03 05:53:23 riastradh Exp $");
+__KERNEL_RCSID(0, "$NetBSD: if_smsc.c,v 1.84 2022/03/03 05:53:33 riastradh Exp $");
 
 #ifdef _KERNEL_OPT
 #include "opt_usb.h"
@@ -563,9 +563,6 @@
        /* Reset the ethernet interface. */
        smsc_reset(sc);
 
-       /* Load the multicast filter. */
-       smsc_uno_mcast(ifp);
-
        /* TCP/UDP checksum offload engines. */
        smsc_setoe_locked(un);
 
diff -r dbe3ef6cf09f -r 58aae5da573a sys/dev/usb/if_udav.c
--- a/sys/dev/usb/if_udav.c     Thu Mar 03 05:53:23 2022 +0000
+++ b/sys/dev/usb/if_udav.c     Thu Mar 03 05:53:33 2022 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: if_udav.c,v 1.88 2022/03/03 05:53:23 riastradh Exp $   */
+/*     $NetBSD: if_udav.c,v 1.89 2022/03/03 05:53:33 riastradh Exp $   */
 /*     $nabe: if_udav.c,v 1.3 2003/08/21 16:57:19 nabe Exp $   */
 
 /*
@@ -45,7 +45,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: if_udav.c,v 1.88 2022/03/03 05:53:23 riastradh Exp $");
+__KERNEL_RCSID(0, "$NetBSD: if_udav.c,v 1.89 2022/03/03 05:53:33 riastradh Exp $");
 
 #ifdef _KERNEL_OPT
 #include "opt_usb.h"
@@ -494,9 +494,6 @@
        else
                UDAV_CLRBIT(un, UDAV_RCR, UDAV_RCR_ALL | UDAV_RCR_PRMSC);
 
-       /* Load the multicast filter */
-       udav_uno_mcast(ifp);
-
        /* Enable RX */
        UDAV_SETBIT(un, UDAV_RCR, UDAV_RCR_RXEN);
 
diff -r dbe3ef6cf09f -r 58aae5da573a sys/dev/usb/if_ure.c
--- a/sys/dev/usb/if_ure.c      Thu Mar 03 05:53:23 2022 +0000
+++ b/sys/dev/usb/if_ure.c      Thu Mar 03 05:53:33 2022 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: if_ure.c,v 1.49 2022/03/03 05:53:23 riastradh Exp $    */
+/*     $NetBSD: if_ure.c,v 1.50 2022/03/03 05:53:33 riastradh Exp $    */
 /*     $OpenBSD: if_ure.c,v 1.10 2018/11/02 21:32:30 jcs Exp $ */
 
 /*-
@@ -30,7 +30,7 @@
 /* RealTek RTL8152/RTL8153 10/100/Gigabit USB Ethernet device */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: if_ure.c,v 1.49 2022/03/03 05:53:23 riastradh Exp $");
+__KERNEL_RCSID(0, "$NetBSD: if_ure.c,v 1.50 2022/03/03 05:53:33 riastradh Exp $");
 
 #ifdef _KERNEL_OPT
 #include "opt_usb.h"
@@ -445,9 +445,6 @@
            ure_read_2(un, URE_PLA_MISC_1, URE_MCU_TYPE_PLA) &
            ~URE_RXDY_GATED_EN);
 
-       /* Accept multicast frame or run promisc. mode. */
-       ure_uno_mcast(ifp);
-
        return usbnet_init_rx_tx(un);
 }
 
diff -r dbe3ef6cf09f -r 58aae5da573a sys/dev/usb/if_url.c
--- a/sys/dev/usb/if_url.c      Thu Mar 03 05:53:23 2022 +0000
+++ b/sys/dev/usb/if_url.c      Thu Mar 03 05:53:33 2022 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: if_url.c,v 1.88 2022/03/03 05:53:23 riastradh Exp $    */
+/*     $NetBSD: if_url.c,v 1.89 2022/03/03 05:53:33 riastradh Exp $    */
 
 /*
  * Copyright (c) 2001, 2002
@@ -44,7 +44,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: if_url.c,v 1.88 2022/03/03 05:53:23 riastradh Exp $");
+__KERNEL_RCSID(0, "$NetBSD: if_url.c,v 1.89 2022/03/03 05:53:33 riastradh Exp $");
 
 #ifdef _KERNEL_OPT
 #include "opt_inet.h"
@@ -389,9 +389,6 @@
        /* Init receive control register */
Prev by Date: [src/trunk]: src/sys/dev/usb usbnet: Apply hardware multicast filter updates ...
Next by Date: [src/trunk]: src/sys/dev/usb aue(4): Enable rx/tx registers on init before us...
Previous by Thread: [src/trunk]: src/sys/dev/usb usbnet: Apply hardware multicast filter updates ...
Next by Thread: [src/trunk]: src/sys/dev/usb aue(4): Enable rx/tx registers on init before us...
Indexes:
Home | Main Index | Thread Index | Old Index