[src/trunk]: src/sys/dev/usb aue(4): Reduce aue_uno_mcast from aue_uno_init t...

[riastradh <riastradh%NetBSD.org@localhost>]

details:   https://anonhg.NetBSD.org/src/rev/9fb11c787f9e
branches:  trunk
changeset: 362528:9fb11c787f9e
user:      riastradh <riastradh%NetBSD.org@localhost>
date:      Thu Mar 03 05:52:55 2022 +0000

description:
aue(4): Reduce aue_uno_mcast from aue_uno_init to aue_setiff_locked.

This operation only needs to update the hardware to reflect
SIOCADDMULTI/SIOCDELMULTI.  Not clear that everything in aue(4) needs
to be reset -- in fact I'm pretty sure that's undesirable!

WARNING: I have not tested this with a real aue(4) device.

diffstat:

 sys/dev/usb/if_aue.c |  10 +++-------
 1 files changed, 3 insertions(+), 7 deletions(-)

diffs (31 lines):

diff -r f90403f67fd4 -r 9fb11c787f9e sys/dev/usb/if_aue.c
--- a/sys/dev/usb/if_aue.c      Thu Mar 03 05:52:46 2022 +0000
+++ b/sys/dev/usb/if_aue.c      Thu Mar 03 05:52:55 2022 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: if_aue.c,v 1.177 2022/03/03 05:52:46 riastradh Exp $   */
+/*     $NetBSD: if_aue.c,v 1.178 2022/03/03 05:52:55 riastradh Exp $   */
 
 /*
  * Copyright (c) 1997, 1998, 1999, 2000
@@ -76,7 +76,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: if_aue.c,v 1.177 2022/03/03 05:52:46 riastradh Exp $");
+__KERNEL_RCSID(0, "$NetBSD: if_aue.c,v 1.178 2022/03/03 05:52:55 riastradh Exp $");
 
 #ifdef _KERNEL_OPT
 #include "opt_usb.h"
@@ -1009,11 +1009,7 @@
            device_unit(((struct usbnet *)(ifp->if_softc))->un_dev),
            0, 0, 0);
 
-       /*
-        * XXX I feel like this is pretty heavy-handed!  Maybe we could
-        * make do with aue_setiff_locked instead?
-        */
-       aue_uno_init(ifp);
+       aue_setiff_locked(ifp);
 }
 
 static void