Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/dev/usb usbnet: Don't check if_flags for IFF_RUNNING in ...



details:   https://anonhg.NetBSD.org/src/rev/d5ae0795a30f
branches:  trunk
changeset: 362491:d5ae0795a30f
user:      riastradh <riastradh%NetBSD.org@localhost>
date:      Thu Mar 03 05:47:50 2022 +0000

description:
usbnet: Don't check if_flags for IFF_RUNNING in usbnet_pipe_intr.

The one user of this interface in tree, aue(4), doesn't care --
if_statinc is safe whether IFF_RUNNING or not.

diffstat:

 sys/dev/usb/usbnet.c |  7 +++----
 1 files changed, 3 insertions(+), 4 deletions(-)

diffs (31 lines):

diff -r 094938575909 -r d5ae0795a30f sys/dev/usb/usbnet.c
--- a/sys/dev/usb/usbnet.c      Thu Mar 03 05:47:43 2022 +0000
+++ b/sys/dev/usb/usbnet.c      Thu Mar 03 05:47:50 2022 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: usbnet.c,v 1.52 2022/03/03 05:47:43 riastradh Exp $    */
+/*     $NetBSD: usbnet.c,v 1.53 2022/03/03 05:47:50 riastradh Exp $    */
 
 /*
  * Copyright (c) 2019 Matthew R. Green
@@ -31,7 +31,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: usbnet.c,v 1.52 2022/03/03 05:47:43 riastradh Exp $");
+__KERNEL_RCSID(0, "$NetBSD: usbnet.c,v 1.53 2022/03/03 05:47:50 riastradh Exp $");
 
 #include <sys/param.h>
 #include <sys/kernel.h>
@@ -443,11 +443,10 @@
        struct usbnet * const un = priv;
        struct usbnet_private * const unp = un->un_pri;
        struct usbnet_intr * const uni = un->un_intr;
-       struct ifnet * const ifp = usbnet_ifp(un);
 
        if (uni == NULL || unp->unp_dying || unp->unp_stopping ||
            status == USBD_INVAL || status == USBD_NOT_STARTED ||
-           status == USBD_CANCELLED || !(ifp->if_flags & IFF_RUNNING)) {
+           status == USBD_CANCELLED) {
                USBNETHIST_CALLARGS("%jd: uni %#jx d/s %#jx status %#jx",
                    unp->unp_number, (uintptr_t)uni,
                    (unp->unp_dying << 8) | unp->unp_stopping, status);



Home | Main Index | Thread Index | Old Index