Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/dev/pci vmx(4): Omit needless membar_sync wrapper.



details:   https://anonhg.NetBSD.org/src/rev/9a42be8fcd07
branches:  trunk
changeset: 361551:9a42be8fcd07
user:      riastradh <riastradh%NetBSD.org@localhost>
date:      Sun Feb 13 19:07:38 2022 +0000

description:
vmx(4): Omit needless membar_sync wrapper.

Nothing uses this, and it is unlikely that any part of this driver
will need store-before-load ordering to synchronize with the host.

diffstat:

 sys/dev/pci/if_vmx.c |  8 ++------
 1 files changed, 2 insertions(+), 6 deletions(-)

diffs (36 lines):

diff -r 47fffd16f65e -r 9a42be8fcd07 sys/dev/pci/if_vmx.c
--- a/sys/dev/pci/if_vmx.c      Sun Feb 13 19:03:25 2022 +0000
+++ b/sys/dev/pci/if_vmx.c      Sun Feb 13 19:07:38 2022 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: if_vmx.c,v 1.5 2021/10/13 01:11:29 knakahara Exp $     */
+/*     $NetBSD: if_vmx.c,v 1.6 2022/02/13 19:07:38 riastradh Exp $     */
 /*     $OpenBSD: if_vmx.c,v 1.16 2014/01/22 06:04:17 brad Exp $        */
 
 /*
@@ -19,7 +19,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: if_vmx.c,v 1.5 2021/10/13 01:11:29 knakahara Exp $");
+__KERNEL_RCSID(0, "$NetBSD: if_vmx.c,v 1.6 2022/02/13 19:07:38 riastradh Exp $");
 
 #include <sys/param.h>
 #include <sys/cpu.h>
@@ -341,7 +341,6 @@
 typedef enum {
        VMXNET3_BARRIER_RD,
        VMXNET3_BARRIER_WR,
-       VMXNET3_BARRIER_RDWR,
 } vmxnet3_barrier_t;
 
 #define JUMBO_LEN (MCLBYTES - ETHER_ALIGN)     /* XXX */
@@ -557,9 +556,6 @@
        case VMXNET3_BARRIER_WR:
                membar_producer();
                break;
-       case VMXNET3_BARRIER_RDWR:
-               membar_sync();
-               break;
        default:
                panic("%s: bad barrier type %d", __func__, type);
        }



Home | Main Index | Thread Index | Old Index