Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/arch/acorn32/include acorn32: Partial __cpu_simple_lock ...



details:   https://anonhg.NetBSD.org/src/rev/2b7d5131b714
branches:  trunk
changeset: 361540:2b7d5131b714
user:      riastradh <riastradh%NetBSD.org@localhost>
date:      Sun Feb 13 13:41:26 2022 +0000

description:
acorn32: Partial __cpu_simple_lock membar audit.

For __cpu_simple_unlock, __insn_barrier is absolutely required.
Whether we need a stronger memory barrier, I don't know offhand and
I'm not sure what the right architecture manual to consult is -- it's
not clear why this isn't just using the generic arm lock.h.

diffstat:

 sys/arch/acorn32/include/lock.h |  3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diffs (17 lines):

diff -r ae106ef1f429 -r 2b7d5131b714 sys/arch/acorn32/include/lock.h
--- a/sys/arch/acorn32/include/lock.h   Sun Feb 13 13:41:17 2022 +0000
+++ b/sys/arch/acorn32/include/lock.h   Sun Feb 13 13:41:26 2022 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: lock.h,v 1.9 2009/01/15 01:11:32 pooka Exp $   */
+/*     $NetBSD: lock.h,v 1.10 2022/02/13 13:41:26 riastradh Exp $      */
 
 /*-
  * Copyright (c) 2000, 2001 The NetBSD Foundation, Inc.
@@ -82,6 +82,7 @@
 __cpu_simple_unlock(__cpu_simple_lock_t *alp)
 {
 
+       __insn_barrier();
        *alp = __SIMPLELOCK_UNLOCKED;
 }
 



Home | Main Index | Thread Index | Old Index