Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/usr.bin/make/unit-tests tests/make: clean up comments in tes...



details:   https://anonhg.NetBSD.org/src/rev/d81d3e85d840
branches:  trunk
changeset: 361163:d81d3e85d840
user:      rillig <rillig%NetBSD.org@localhost>
date:      Sat Feb 12 20:05:36 2022 +0000

description:
tests/make: clean up comments in test for indirect -k failures

See PR#49720.

diffstat:

 usr.bin/make/unit-tests/opt-keep-going-indirect.mk |  30 +++++++++++----------
 1 files changed, 16 insertions(+), 14 deletions(-)

diffs (59 lines):

diff -r 02c6ae16052a -r d81d3e85d840 usr.bin/make/unit-tests/opt-keep-going-indirect.mk
--- a/usr.bin/make/unit-tests/opt-keep-going-indirect.mk        Sat Feb 12 19:56:52 2022 +0000
+++ b/usr.bin/make/unit-tests/opt-keep-going-indirect.mk        Sat Feb 12 20:05:36 2022 +0000
@@ -1,4 +1,4 @@
-# $NetBSD: opt-keep-going-indirect.mk,v 1.1 2022/02/12 13:17:57 rillig Exp $
+# $NetBSD: opt-keep-going-indirect.mk,v 1.2 2022/02/12 20:05:36 rillig Exp $
 #
 # Tests for the -k command line option, which stops building a target as soon
 # as an error is detected, but continues building the other, independent
@@ -6,27 +6,28 @@
 #
 # History:
 #      In 1993, the exit status for the option '-k' was always 0, even if a
-#      a direct or an indirect target failed.
+#      direct or an indirect target failed.
 #
 #      Since 2000.12.30.02.05.21, the word '(continuing)' is missing in jobs
 #      mode, both for direct as well as indirect targets.
 #
 #      Since 2001.10.16.18.50.12, the exit status for a direct failure in
-#      compat mode is 1, while jobs mode and indirect failures still return
-#      exit status 0.  The number of empty lines between the various error
-#      messages differs between the modes, for no reason.
+#      compat mode is the correct 1, while jobs mode and indirect failures
+#      still return the wrong exit status 0.  The number of empty lines
+#      between the various error messages differs between the modes, for no
+#      reason.
 #
 #      At 2006.11.17.22.07.39, the exit status for direct failures in both
-#      modes and for indirect failures in jobs mode was corrected, leaving
-#      only indirect failures in compat mode wrong.  On the downside, a
-#      failed indirect target in jobs mode was no longer listed as "not
-#      remade because of errors".
+#      modes and for indirect failures in jobs mode was fixed to the correct
+#      1.  The exit status for indirect failures in compat mode is still the
+#      wrong 0.  On the downside, a failed indirect target in jobs mode is no
+#      longer listed as "not remade because of errors".
 #
-#      At 2016.08.26.23.28.39, the additional empty lines for a direct
-#      failure in compat mode was removed, making it consistent with a direct
-#      failure in jobs mode.  This left only one inconsistency, in that
-#      indirect failures in jobs mode (by far the most common when building
-#      large projects) did not produce any empty line.
+#      At 2016.08.26.23.28.39, the additional empty line for a direct failure
+#      in compat mode was removed, making it consistent with a direct failure
+#      in jobs mode.  This left only one inconsistency, in that indirect
+#      failures in jobs mode (by far the most common when building large
+#      projects) did not produce any empty line.
 #
 #      Since 2020.12.07.00.53.30, the exit status is consistently 1 for
 #      failures in all 4 modes.
@@ -83,6 +84,7 @@
 # expect: exited 1
 
 # TODO: Add '(continuing)'.
+# TODO: Add 'not remade because of errors'.
 # expect: indirect jobs
 # expect: *** [direct] Error code 1
 # expect: exited 1



Home | Main Index | Thread Index | Old Index