Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/dev/usb don't 'extern' some other .c file's data, espcia...



details:   https://anonhg.NetBSD.org/src/rev/feb8c935026c
branches:  trunk
changeset: 359737:feb8c935026c
user:      mrg <mrg%NetBSD.org@localhost>
date:      Thu Jan 20 03:14:03 2022 +0000

description:
don't 'extern' some other .c file's data, espcially when it's
already in usbhist.h.

diffstat:

 sys/dev/usb/usb_quirks.c |  8 ++------
 sys/dev/usb/usbdi.c      |  6 ++----
 sys/dev/usb/usbroothub.c |  6 ++----
 3 files changed, 6 insertions(+), 14 deletions(-)

diffs (83 lines):

diff -r b8b43947a028 -r feb8c935026c sys/dev/usb/usb_quirks.c
--- a/sys/dev/usb/usb_quirks.c  Wed Jan 19 22:10:41 2022 +0000
+++ b/sys/dev/usb/usb_quirks.c  Thu Jan 20 03:14:03 2022 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: usb_quirks.c,v 1.103 2022/01/17 11:12:28 bouyer Exp $  */
+/*     $NetBSD: usb_quirks.c,v 1.104 2022/01/20 03:14:03 mrg Exp $     */
 /*     $FreeBSD: src/sys/dev/usb/usb_quirks.c,v 1.30 2003/01/02 04:15:55 imp Exp $     */
 
 /*
@@ -32,7 +32,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: usb_quirks.c,v 1.103 2022/01/17 11:12:28 bouyer Exp $");
+__KERNEL_RCSID(0, "$NetBSD: usb_quirks.c,v 1.104 2022/01/20 03:14:03 mrg Exp $");
 
 #ifdef _KERNEL_OPT
 #include "opt_usb.h"
@@ -48,10 +48,6 @@
 #include <dev/usb/usbhist.h>
 #include <dev/usb/usb_quirks.h>
 
-#ifdef USB_DEBUG
-extern int usbdebug;
-#endif
-
 #define DPRINTF(FMT,A,B,C,D)    USBHIST_LOG(usbdebug,FMT,A,B,C,D)
 
 #define ANY 0xffff
diff -r b8b43947a028 -r feb8c935026c sys/dev/usb/usbdi.c
--- a/sys/dev/usb/usbdi.c       Wed Jan 19 22:10:41 2022 +0000
+++ b/sys/dev/usb/usbdi.c       Thu Jan 20 03:14:03 2022 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: usbdi.c,v 1.221 2021/12/31 12:00:18 skrll Exp $        */
+/*     $NetBSD: usbdi.c,v 1.222 2022/01/20 03:14:03 mrg Exp $  */
 
 /*
  * Copyright (c) 1998, 2012, 2015 The NetBSD Foundation, Inc.
@@ -32,7 +32,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: usbdi.c,v 1.221 2021/12/31 12:00:18 skrll Exp $");
+__KERNEL_RCSID(0, "$NetBSD: usbdi.c,v 1.222 2022/01/20 03:14:03 mrg Exp $");
 
 #ifdef _KERNEL_OPT
 #include "opt_usb.h"
@@ -61,8 +61,6 @@
 /* UTF-8 encoding stuff */
 #include <fs/unicode.h>
 
-extern int usbdebug;
-
 SDT_PROBE_DEFINE5(usb, device, pipe, open,
     "struct usbd_interface *"/*iface*/,
     "uint8_t"/*address*/,
diff -r b8b43947a028 -r feb8c935026c sys/dev/usb/usbroothub.c
--- a/sys/dev/usb/usbroothub.c  Wed Jan 19 22:10:41 2022 +0000
+++ b/sys/dev/usb/usbroothub.c  Thu Jan 20 03:14:03 2022 +0000
@@ -1,4 +1,4 @@
-/* $NetBSD: usbroothub.c,v 1.10 2021/07/21 06:35:45 skrll Exp $ */
+/* $NetBSD: usbroothub.c,v 1.11 2022/01/20 03:14:03 mrg Exp $ */
 
 /*-
  * Copyright (c) 1998, 2004, 2011, 2012 The NetBSD Foundation, Inc.
@@ -58,7 +58,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: usbroothub.c,v 1.10 2021/07/21 06:35:45 skrll Exp $");
+__KERNEL_RCSID(0, "$NetBSD: usbroothub.c,v 1.11 2022/01/20 03:14:03 mrg Exp $");
 
 #include <sys/param.h>
 #include <sys/systm.h>         /* for ostype */
@@ -69,8 +69,6 @@
 #include <dev/usb/usbroothub.h>
 #include <dev/usb/usbhist.h>
 
-extern int usbdebug;
-
 /* helper functions for USB root hub emulation */
 
 static usbd_status     roothub_ctrl_transfer(struct usbd_xfer *);



Home | Main Index | Thread Index | Old Index