Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/external/bsd/drm2/dist/drm/i915/gem i915: Avoid leaking ...



details:   https://anonhg.NetBSD.org/src/rev/e695cb8743f7
branches:  trunk
changeset: 1028821:e695cb8743f7
user:      riastradh <riastradh%NetBSD.org@localhost>
date:      Sun Dec 19 12:08:27 2021 +0000

description:
i915: Avoid leaking reference count when mapping objects.

We already did i915_gem_object_get_rcu above, which bumps the
reference count; no need to additionally do drm_gem_object_get.

diffstat:

 sys/external/bsd/drm2/dist/drm/i915/gem/i915_gem_mman.c |  5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

diffs (26 lines):

diff -r c629d437cde9 -r e695cb8743f7 sys/external/bsd/drm2/dist/drm/i915/gem/i915_gem_mman.c
--- a/sys/external/bsd/drm2/dist/drm/i915/gem/i915_gem_mman.c   Sun Dec 19 12:08:18 2021 +0000
+++ b/sys/external/bsd/drm2/dist/drm/i915/gem/i915_gem_mman.c   Sun Dec 19 12:08:27 2021 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: i915_gem_mman.c,v 1.14 2021/12/19 12:08:10 riastradh Exp $     */
+/*     $NetBSD: i915_gem_mman.c,v 1.15 2021/12/19 12:08:27 riastradh Exp $     */
 
 /*
  * SPDX-License-Identifier: MIT
@@ -7,7 +7,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: i915_gem_mman.c,v 1.14 2021/12/19 12:08:10 riastradh Exp $");
+__KERNEL_RCSID(0, "$NetBSD: i915_gem_mman.c,v 1.15 2021/12/19 12:08:27 riastradh Exp $");
 
 #include <linux/anon_inodes.h>
 #include <linux/mman.h>
@@ -1077,7 +1077,6 @@
        }
 
        /* Success!  */
-       drm_gem_object_get(&obj->base);
        *uobjp = &obj->base.gemo_uvmobj;
        *uoffsetp = 0;
        return 0;



Home | Main Index | Thread Index | Old Index