Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/arch/aarch64/include Normally, to support COMPAT_NETBSD3...



details:   https://anonhg.NetBSD.org/src/rev/27629fa20f11
branches:  trunk
changeset: 1024794:27629fa20f11
user:      thorpej <thorpej%NetBSD.org@localhost>
date:      Fri Nov 05 15:18:18 2021 +0000

description:
Normally, to support COMPAT_NETBSD32 we need to define
__HAVE_STRUCT_SIGCONTEXT in order to support the old
"sigcontext" style of handlers for 32-bit binaries.
However, we only support 32-bit EABI binaries on AArch64,
and by happy accident (due to a libc bug introduced in
2006), 32-bit NetBSD EABI binaries never used "sigcontext"
style handlers.  So, we don't need to carry any of this
baggage forward.

This addresses the AArch64 case of PR kern/56487.

diffstat:

 sys/arch/aarch64/include/signal.h |  14 +++++++++++---
 1 files changed, 11 insertions(+), 3 deletions(-)

diffs (28 lines):

diff -r 810c8b5693be -r 27629fa20f11 sys/arch/aarch64/include/signal.h
--- a/sys/arch/aarch64/include/signal.h Fri Nov 05 07:39:22 2021 +0000
+++ b/sys/arch/aarch64/include/signal.h Fri Nov 05 15:18:18 2021 +0000
@@ -1,4 +1,4 @@
-/* $NetBSD: signal.h,v 1.3 2021/10/27 04:45:42 thorpej Exp $ */
+/* $NetBSD: signal.h,v 1.4 2021/11/05 15:18:18 thorpej Exp $ */
 
 #ifndef _AARCH64_SIGNAL_H_
 #define        _AARCH64_SIGNAL_H_
@@ -6,8 +6,16 @@
 #include <arm/signal.h>
 
 #ifdef _KERNEL
-/* This is needed to support COMPAT_NETBSD32. */ 
-#define        __HAVE_STRUCT_SIGCONTEXT
+/*
+ * Normally, to support COMPAT_NETBSD32 we need to define
+ * __HAVE_STRUCT_SIGCONTEXT in order to support the old
+ * "sigcontext" style of handlers for 32-bit binaries.
+ * However, we only support 32-bit EABI binaries on AArch64,
+ * and by happy accident (due to a libc bug introduced in
+ * 2006), 32-bit NetBSD EABI binaries never used "sigcontext"
+ * style handlers.  So, we don't need to carry any of this
+ * baggage forward.
+ */
 #endif /* _KERNEL */
 
 #endif /* ! _AARCH64_SIGNAL_H_ */



Home | Main Index | Thread Index | Old Index