Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/bin/sh sh: remove no-op 'continue' from do-while-0 loop



details:   https://anonhg.NetBSD.org/src/rev/2691c9616030
branches:  trunk
changeset: 1024105:2691c9616030
user:      rillig <rillig%NetBSD.org@localhost>
date:      Sun Oct 10 08:35:34 2021 +0000

description:
sh: remove no-op 'continue' from do-while-0 loop

With Clang, the only change to the binary are the line number changes
from __LINE__, GCC generates a bit different code.

No functional change.

diffstat:

 bin/sh/Makefile |  3 +--
 bin/sh/jobs.c   |  8 +++-----
 2 files changed, 4 insertions(+), 7 deletions(-)

diffs (47 lines):

diff -r 2bc81b248155 -r 2691c9616030 bin/sh/Makefile
--- a/bin/sh/Makefile   Sun Oct 10 08:19:02 2021 +0000
+++ b/bin/sh/Makefile   Sun Oct 10 08:35:34 2021 +0000
@@ -1,4 +1,4 @@
-#      $NetBSD: Makefile,v 1.119 2021/10/09 21:06:31 rillig Exp $
+#      $NetBSD: Makefile,v 1.120 2021/10/10 08:35:34 rillig Exp $
 #      @(#)Makefile    8.4 (Berkeley) 5/5/95
 
 .include <bsd.own.mk>
@@ -30,7 +30,6 @@
 #COPTS+=-g
 #CFLAGS+=-funsigned-char
 #TARGET_CHARFLAG?= -DTARGET_CHAR="unsigned char" -funsigned-char
-LINTFLAGS+=    -X 323          # continue in 'do ... while (0)' loop
 
 # Reproducible build parameters ... export into sh for NETBSD_SHELL setting
 .if ${MKREPRO_TIMESTAMP:Uno} != "no"
diff -r 2bc81b248155 -r 2691c9616030 bin/sh/jobs.c
--- a/bin/sh/jobs.c     Sun Oct 10 08:19:02 2021 +0000
+++ b/bin/sh/jobs.c     Sun Oct 10 08:35:34 2021 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: jobs.c,v 1.112 2021/09/12 01:30:41 kre Exp $   */
+/*     $NetBSD: jobs.c,v 1.113 2021/10/10 08:35:34 rillig Exp $        */
 
 /*-
  * Copyright (c) 1991, 1993
@@ -37,7 +37,7 @@
 #if 0
 static char sccsid[] = "@(#)jobs.c     8.5 (Berkeley) 5/4/95";
 #else
-__RCSID("$NetBSD: jobs.c,v 1.112 2021/09/12 01:30:41 kre Exp $");
+__RCSID("$NetBSD: jobs.c,v 1.113 2021/10/10 08:35:34 rillig Exp $");
 #endif
 #endif /* not lint */
 
@@ -196,10 +196,8 @@
                        }
                        if (initialpgrp == -1)
                                initialpgrp = getpgrp();
-                       else if (initialpgrp != getpgrp()) {
+                       else if (initialpgrp != getpgrp())
                                killpg(0, SIGTTIN);
-                               continue;
-                       }
                } while (0);
 
 #ifdef OLD_TTY_DRIVER



Home | Main Index | Thread Index | Old Index