Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/arch Driver "kqfilter" entry points return an error code...



details:   https://anonhg.NetBSD.org/src/rev/b227cbc475ff
branches:  trunk
changeset: 1023805:b227cbc475ff
user:      thorpej <thorpej%NetBSD.org@localhost>
date:      Sun Sep 26 16:36:18 2021 +0000

description:
Driver "kqfilter" entry points return an error code, so if an invalid
filter is requested, return EINVAL rather than 1.

diffstat:

 sys/arch/amiga/dev/event.c       |  6 +++---
 sys/arch/arc/dev/opms.c          |  6 +++---
 sys/arch/arm/xscale/pxa2x0_apm.c |  4 ++--
 sys/arch/atari/dev/event.c       |  6 +++---
 sys/arch/landisk/dev/button.c    |  6 +++---
 sys/arch/mac68k/dev/aed.c        |  6 +++---
 sys/arch/macppc/dev/aed.c        |  6 +++---
 sys/arch/macppc/dev/apm.c        |  6 +++---
 sys/arch/sparc/dev/tctrl.c       |  6 +++---
 sys/arch/x68k/dev/event.c        |  6 +++---
 10 files changed, 29 insertions(+), 29 deletions(-)

diffs (261 lines):

diff -r 507ea7cd75dc -r b227cbc475ff sys/arch/amiga/dev/event.c
--- a/sys/arch/amiga/dev/event.c        Sun Sep 26 16:24:21 2021 +0000
+++ b/sys/arch/amiga/dev/event.c        Sun Sep 26 16:36:18 2021 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: event.c,v 1.16 2021/09/26 01:16:07 thorpej Exp $ */
+/*     $NetBSD: event.c,v 1.17 2021/09/26 16:36:18 thorpej Exp $ */
 
 /*
  * Copyright (c) 1992, 1993
@@ -43,7 +43,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: event.c,v 1.16 2021/09/26 01:16:07 thorpej Exp $");
+__KERNEL_RCSID(0, "$NetBSD: event.c,v 1.17 2021/09/26 16:36:18 thorpej Exp $");
 
 /*
  * Internal `Firm_event' interface for the keyboard and mouse drivers.
@@ -208,7 +208,7 @@
                break;
 
        default:
-               return (1);
+               return (EINVAL);
        }
 
        kn->kn_hook = ev;
diff -r 507ea7cd75dc -r b227cbc475ff sys/arch/arc/dev/opms.c
--- a/sys/arch/arc/dev/opms.c   Sun Sep 26 16:24:21 2021 +0000
+++ b/sys/arch/arc/dev/opms.c   Sun Sep 26 16:36:18 2021 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: opms.c,v 1.25 2021/09/26 01:16:07 thorpej Exp $        */
+/*     $NetBSD: opms.c,v 1.26 2021/09/26 16:36:18 thorpej Exp $        */
 /*     $OpenBSD: pccons.c,v 1.22 1999/01/30 22:39:37 imp Exp $ */
 /*     NetBSD: pms.c,v 1.21 1995/04/18 02:25:18 mycroft Exp    */
 
@@ -80,7 +80,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: opms.c,v 1.25 2021/09/26 01:16:07 thorpej Exp $");
+__KERNEL_RCSID(0, "$NetBSD: opms.c,v 1.26 2021/09/26 16:36:18 thorpej Exp $");
 
 #include <sys/param.h>
 #include <sys/systm.h>
@@ -491,7 +491,7 @@
                break;
 
        default:
-               return 1;
+               return EINVAL;
        }
 
        kn->kn_hook = sc;
diff -r 507ea7cd75dc -r b227cbc475ff sys/arch/arm/xscale/pxa2x0_apm.c
--- a/sys/arch/arm/xscale/pxa2x0_apm.c  Sun Sep 26 16:24:21 2021 +0000
+++ b/sys/arch/arm/xscale/pxa2x0_apm.c  Sun Sep 26 16:36:18 2021 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: pxa2x0_apm.c,v 1.6 2021/09/26 01:16:07 thorpej Exp $   */
+/*     $NetBSD: pxa2x0_apm.c,v 1.7 2021/09/26 16:36:18 thorpej Exp $   */
 /*     $OpenBSD: pxa2x0_apm.c,v 1.28 2007/03/29 18:42:38 uwe Exp $     */
 
 /*-
@@ -629,7 +629,7 @@
                kn->kn_fop = &apmread_filtops;
                break;
        default:
-               return (1);
+               return (EINVAL);
        }
 
        kn->kn_hook = (caddr_t)sc;
diff -r 507ea7cd75dc -r b227cbc475ff sys/arch/atari/dev/event.c
--- a/sys/arch/atari/dev/event.c        Sun Sep 26 16:24:21 2021 +0000
+++ b/sys/arch/atari/dev/event.c        Sun Sep 26 16:36:18 2021 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: event.c,v 1.16 2021/09/26 01:16:07 thorpej Exp $       */
+/*     $NetBSD: event.c,v 1.17 2021/09/26 16:36:18 thorpej Exp $       */
 
 /*
  * Copyright (c) 1992, 1993
@@ -47,7 +47,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: event.c,v 1.16 2021/09/26 01:16:07 thorpej Exp $");
+__KERNEL_RCSID(0, "$NetBSD: event.c,v 1.17 2021/09/26 16:36:18 thorpej Exp $");
 
 #include <sys/param.h>
 #include <sys/fcntl.h>
@@ -208,7 +208,7 @@
                break;
 
        default:
-               return (1);
+               return (EINVAL);
        }
 
        kn->kn_hook = ev;
diff -r 507ea7cd75dc -r b227cbc475ff sys/arch/landisk/dev/button.c
--- a/sys/arch/landisk/dev/button.c     Sun Sep 26 16:24:21 2021 +0000
+++ b/sys/arch/landisk/dev/button.c     Sun Sep 26 16:36:18 2021 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: button.c,v 1.13 2021/09/26 14:32:02 thorpej Exp $      */
+/*     $NetBSD: button.c,v 1.14 2021/09/26 16:36:18 thorpej Exp $      */
 
 /*
  * Copyright (c) 2003 Wasabi Systems, Inc.
@@ -36,7 +36,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: button.c,v 1.13 2021/09/26 14:32:02 thorpej Exp $");
+__KERNEL_RCSID(0, "$NetBSD: button.c,v 1.14 2021/09/26 16:36:18 thorpej Exp $");
 
 #include <sys/param.h>
 #include <sys/conf.h>
@@ -333,7 +333,7 @@
                break;
 
        default:
-               return (1);
+               return (EINVAL);
        }
 
        return (0);
diff -r 507ea7cd75dc -r b227cbc475ff sys/arch/mac68k/dev/aed.c
--- a/sys/arch/mac68k/dev/aed.c Sun Sep 26 16:24:21 2021 +0000
+++ b/sys/arch/mac68k/dev/aed.c Sun Sep 26 16:36:18 2021 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: aed.c,v 1.37 2021/09/26 14:36:48 thorpej Exp $ */
+/*     $NetBSD: aed.c,v 1.38 2021/09/26 16:36:18 thorpej Exp $ */
 
 /*
  * Copyright (C) 1994  Bradley A. Grantham
@@ -26,7 +26,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: aed.c,v 1.37 2021/09/26 14:36:48 thorpej Exp $");
+__KERNEL_RCSID(0, "$NetBSD: aed.c,v 1.38 2021/09/26 16:36:18 thorpej Exp $");
 
 #include "opt_adb.h"
 
@@ -622,7 +622,7 @@
                break;
 
        default:
-               return (1);
+               return (EINVAL);
        }
 
        return (0);
diff -r 507ea7cd75dc -r b227cbc475ff sys/arch/macppc/dev/aed.c
--- a/sys/arch/macppc/dev/aed.c Sun Sep 26 16:24:21 2021 +0000
+++ b/sys/arch/macppc/dev/aed.c Sun Sep 26 16:36:18 2021 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: aed.c,v 1.33 2021/09/26 14:36:48 thorpej Exp $ */
+/*     $NetBSD: aed.c,v 1.34 2021/09/26 16:36:19 thorpej Exp $ */
 
 /*
  * Copyright (C) 1994  Bradley A. Grantham
@@ -26,7 +26,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: aed.c,v 1.33 2021/09/26 14:36:48 thorpej Exp $");
+__KERNEL_RCSID(0, "$NetBSD: aed.c,v 1.34 2021/09/26 16:36:19 thorpej Exp $");
 
 #include <sys/param.h>
 #include <sys/device.h>
@@ -627,7 +627,7 @@
                break;
 
        default:
-               return (1);
+               return (EINVAL);
        }
 
        return (0);
diff -r 507ea7cd75dc -r b227cbc475ff sys/arch/macppc/dev/apm.c
--- a/sys/arch/macppc/dev/apm.c Sun Sep 26 16:24:21 2021 +0000
+++ b/sys/arch/macppc/dev/apm.c Sun Sep 26 16:36:18 2021 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: apm.c,v 1.30 2021/09/26 01:16:07 thorpej Exp $ */
+/*     $NetBSD: apm.c,v 1.31 2021/09/26 16:36:19 thorpej Exp $ */
 /*     $OpenBSD: apm.c,v 1.5 2002/06/07 07:13:59 miod Exp $    */
 
 /*-
@@ -33,7 +33,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: apm.c,v 1.30 2021/09/26 01:16:07 thorpej Exp $");
+__KERNEL_RCSID(0, "$NetBSD: apm.c,v 1.31 2021/09/26 16:36:19 thorpej Exp $");
 
 #include "apm.h"
 
@@ -448,7 +448,7 @@
                kn->kn_fop = &apmread_filtops;
                break;
        default:
-               return (1);
+               return (EINVAL);
        }
 
        kn->kn_hook = sc;
diff -r 507ea7cd75dc -r b227cbc475ff sys/arch/sparc/dev/tctrl.c
--- a/sys/arch/sparc/dev/tctrl.c        Sun Sep 26 16:24:21 2021 +0000
+++ b/sys/arch/sparc/dev/tctrl.c        Sun Sep 26 16:36:18 2021 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: tctrl.c,v 1.64 2021/09/26 01:16:08 thorpej Exp $       */
+/*     $NetBSD: tctrl.c,v 1.65 2021/09/26 16:36:19 thorpej Exp $       */
 
 /*-
  * Copyright (c) 1998, 2005, 2006 The NetBSD Foundation, Inc.
@@ -30,7 +30,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: tctrl.c,v 1.64 2021/09/26 01:16:08 thorpej Exp $");
+__KERNEL_RCSID(0, "$NetBSD: tctrl.c,v 1.65 2021/09/26 16:36:19 thorpej Exp $");
 
 #include <sys/param.h>
 #include <sys/systm.h>
@@ -1251,7 +1251,7 @@
                break;
 
        default:
-               return (1);
+               return (EINVAL);
        }
 
        kn->kn_hook = sc;
diff -r 507ea7cd75dc -r b227cbc475ff sys/arch/x68k/dev/event.c
--- a/sys/arch/x68k/dev/event.c Sun Sep 26 16:24:21 2021 +0000
+++ b/sys/arch/x68k/dev/event.c Sun Sep 26 16:36:18 2021 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: event.c,v 1.18 2021/09/26 01:16:08 thorpej Exp $ */
+/*     $NetBSD: event.c,v 1.19 2021/09/26 16:36:19 thorpej Exp $ */
 
 /*
  * Copyright (c) 1992, 1993
@@ -45,7 +45,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: event.c,v 1.18 2021/09/26 01:16:08 thorpej Exp $");
+__KERNEL_RCSID(0, "$NetBSD: event.c,v 1.19 2021/09/26 16:36:19 thorpej Exp $");
 
 #include <sys/param.h>
 #include <sys/fcntl.h>
@@ -233,7 +233,7 @@
                break;
 
        default:
-               return (1);
+               return (EINVAL);
        }
 
        kn->kn_hook = ev;



Home | Main Index | Thread Index | Old Index