Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/fs/ptyfs Fix ptyfs link and symlink ops.



details:   https://anonhg.NetBSD.org/src/rev/a78487b65229
branches:  trunk
changeset: 1022440:a78487b65229
user:      dholland <dholland%NetBSD.org@localhost>
date:      Sun Jul 18 23:57:34 2021 +0000

description:
Fix ptyfs link and symlink ops.

They were set (via macro obfuscation just eliminated) to
genfs_abortop, which is the wrong thing. These code paths are
currently inaccessible because of EROFS enforcement in namei, but if
either were reached odd behavior would likely ensue. Use
genfs_eopnotsupp like the rest of the ops that don't make sense here.

diffstat:

 sys/fs/ptyfs/ptyfs_vnops.c |  8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diffs (32 lines):

diff -r 04f8244f6346 -r a78487b65229 sys/fs/ptyfs/ptyfs_vnops.c
--- a/sys/fs/ptyfs/ptyfs_vnops.c        Sun Jul 18 23:57:13 2021 +0000
+++ b/sys/fs/ptyfs/ptyfs_vnops.c        Sun Jul 18 23:57:34 2021 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: ptyfs_vnops.c,v 1.65 2021/07/18 23:57:14 dholland Exp $        */
+/*     $NetBSD: ptyfs_vnops.c,v 1.66 2021/07/18 23:57:34 dholland Exp $        */
 
 /*
  * Copyright (c) 1993, 1995
@@ -76,7 +76,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: ptyfs_vnops.c,v 1.65 2021/07/18 23:57:14 dholland Exp $");
+__KERNEL_RCSID(0, "$NetBSD: ptyfs_vnops.c,v 1.66 2021/07/18 23:57:34 dholland Exp $");
 
 #include <sys/param.h>
 #include <sys/systm.h>
@@ -167,11 +167,11 @@
        { &vop_fsync_desc, genfs_nullop },              /* fsync */
        { &vop_seek_desc, genfs_nullop },               /* seek */
        { &vop_remove_desc, genfs_eopnotsupp },         /* remove */
-       { &vop_link_desc, genfs_abortop },              /* link */
+       { &vop_link_desc, genfs_eopnotsupp },           /* link */
        { &vop_rename_desc, genfs_eopnotsupp },         /* rename */
        { &vop_mkdir_desc, genfs_eopnotsupp },          /* mkdir */
        { &vop_rmdir_desc, genfs_eopnotsupp },          /* rmdir */
-       { &vop_symlink_desc, genfs_abortop },           /* symlink */
+       { &vop_symlink_desc, genfs_eopnotsupp },        /* symlink */
        { &vop_readdir_desc, ptyfs_readdir },           /* readdir */
        { &vop_readlink_desc, genfs_eopnotsupp },       /* readlink */
        { &vop_abortop_desc, genfs_abortop },           /* abortop */



Home | Main Index | Thread Index | Old Index