Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/tests/usr.bin/make tests/make: remove ATF descr



details:   https://anonhg.NetBSD.org/src/rev/2e2d53d34915
branches:  trunk
changeset: 1020607:2e2d53d34915
user:      rillig <rillig%NetBSD.org@localhost>
date:      Sat Apr 17 11:36:34 2021 +0000

description:
tests/make: remove ATF descr

The description of the tests is not going to be added anytime soon, as
that would either create redundancy or additional run-time cost.
Parsing and evaluating unit-tests/Makefile is already O(n^2) with regard
to the number of tests, and there are quite a few tests.  Therefore don't
add any overhead for now.

diffstat:

 tests/usr.bin/make/t_make.sh |  9 ++-------
 1 files changed, 2 insertions(+), 7 deletions(-)

diffs (33 lines):

diff -r c3adfef0137e -r 2e2d53d34915 tests/usr.bin/make/t_make.sh
--- a/tests/usr.bin/make/t_make.sh      Sat Apr 17 11:31:25 2021 +0000
+++ b/tests/usr.bin/make/t_make.sh      Sat Apr 17 11:36:34 2021 +0000
@@ -1,4 +1,4 @@
-# $NetBSD: t_make.sh,v 1.14 2021/04/17 11:31:25 rillig Exp $
+# $NetBSD: t_make.sh,v 1.15 2021/04/17 11:36:34 rillig Exp $
 #
 # Copyright (c) 2008, 2010, 2014 The NetBSD Foundation, Inc.
 # All rights reserved.
@@ -53,13 +53,9 @@
 {
        local atfname="${1}"; shift     # e.g. foo_bar
        local makename="${1}"; shift    # e.g. foo-bar
-       local descr="${1}"; shift
 
        atf_test_case "${atfname}"
        eval "${atfname}_head() { \
-               if [ -n '${descr}' ]; then \
-                   atf_set descr '${descr}'; \
-               fi; \
                atf_set require.user unprivileged; \
        }"
        eval "${atfname}_body() { \
@@ -87,8 +83,7 @@
                        (*)     break;;
                        esac
                done
-               descr='' # XXX
-               test_case "${atfname}" "${basename}" "${descr}"
+               test_case "${atfname}" "${basename}"
                atf_add_test_case "${atfname}"
        done
 }



Home | Main Index | Thread Index | Old Index