Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/net Added missing free of sc_hunique to prevent memory leak



details:   https://anonhg.NetBSD.org/src/rev/2d7e50b62815
branches:  trunk
changeset: 982667:2d7e50b62815
user:      yamaguchi <yamaguchi%NetBSD.org@localhost>
date:      Thu Apr 22 10:26:24 2021 +0000

description:
Added missing free of sc_hunique to prevent memory leak
when using PPPoE server

diffstat:

 sys/net/if_pppoe.c |  11 +++++++++--
 1 files changed, 9 insertions(+), 2 deletions(-)

diffs (32 lines):

diff -r 747269bbf127 -r 2d7e50b62815 sys/net/if_pppoe.c
--- a/sys/net/if_pppoe.c        Thu Apr 22 05:00:35 2021 +0000
+++ b/sys/net/if_pppoe.c        Thu Apr 22 10:26:24 2021 +0000
@@ -1,4 +1,4 @@
-/* $NetBSD: if_pppoe.c,v 1.169 2021/04/16 02:23:25 yamaguchi Exp $ */
+/* $NetBSD: if_pppoe.c,v 1.170 2021/04/22 10:26:24 yamaguchi Exp $ */
 
 /*
  * Copyright (c) 2002, 2008 The NetBSD Foundation, Inc.
@@ -30,7 +30,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: if_pppoe.c,v 1.169 2021/04/16 02:23:25 yamaguchi Exp $");
+__KERNEL_RCSID(0, "$NetBSD: if_pppoe.c,v 1.170 2021/04/22 10:26:24 yamaguchi Exp $");
 
 #ifdef _KERNEL_OPT
 #include "pppoe.h"
@@ -448,6 +448,13 @@
        callout_halt(&sc->sc_timeout, NULL);
        callout_destroy(&sc->sc_timeout);
 
+#ifdef PPPOE_SERVER
+       if (sc->sc_hunique) {
+               free(sc->sc_hunique, M_DEVBUF);
+               sc->sc_hunique = NULL;
+               sc->sc_hunique_len = 0;
+       }
+#endif
        if (sc->sc_concentrator_name)
                free(sc->sc_concentrator_name, M_DEVBUF);
        if (sc->sc_service_name)



Home | Main Index | Thread Index | Old Index