Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/dev/hyperv hvn(4), hvkbd(4): No need to call vmbus_chann...



details:   https://anonhg.NetBSD.org/src/rev/aa2b1ff2f0d7
branches:  trunk
changeset: 966771:aa2b1ff2f0d7
user:      nonaka <nonaka%NetBSD.org@localhost>
date:      Fri Nov 15 08:51:27 2019 +0000

description:
hvn(4), hvkbd(4): No need to call vmbus_channel_setdeferred().

These devices do not perform batch reading.

diffstat:

 sys/dev/hyperv/hvkbd.c  |   9 ++-------
 sys/dev/hyperv/if_hvn.c |  10 ++--------
 2 files changed, 4 insertions(+), 15 deletions(-)

diffs (61 lines):

diff -r f909b2d71c1e -r aa2b1ff2f0d7 sys/dev/hyperv/hvkbd.c
--- a/sys/dev/hyperv/hvkbd.c    Fri Nov 15 08:11:36 2019 +0000
+++ b/sys/dev/hyperv/hvkbd.c    Fri Nov 15 08:51:27 2019 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: hvkbd.c,v 1.3 2019/10/01 18:00:08 chs Exp $    */
+/*     $NetBSD: hvkbd.c,v 1.4 2019/11/15 08:51:27 nonaka Exp $ */
 
 /*-
  * Copyright (c) 2017 Microsoft Corp.
@@ -36,7 +36,7 @@
 #endif /* _KERNEL_OPT */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: hvkbd.c,v 1.3 2019/10/01 18:00:08 chs Exp $");
+__KERNEL_RCSID(0, "$NetBSD: hvkbd.c,v 1.4 2019/11/15 08:51:27 nonaka Exp $");
 
 #include <sys/param.h>
 #include <sys/systm.h>
@@ -210,11 +210,6 @@
        hvkbd_alloc_keybuf(sc);
 
        sc->sc_buf = kmem_zalloc(HVKBD_BUFSIZE, KM_SLEEP);
-       if (vmbus_channel_setdeferred(sc->sc_chan, device_xname(self))) {
-               aprint_error_dev(self,
-                   "failed to create the interrupt thread\n");
-               goto free_buf;
-       }
 
        sc->sc_chan->ch_flags &= ~CHF_BATCHED;
        if (vmbus_channel_open(sc->sc_chan,
diff -r f909b2d71c1e -r aa2b1ff2f0d7 sys/dev/hyperv/if_hvn.c
--- a/sys/dev/hyperv/if_hvn.c   Fri Nov 15 08:11:36 2019 +0000
+++ b/sys/dev/hyperv/if_hvn.c   Fri Nov 15 08:51:27 2019 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: if_hvn.c,v 1.5 2019/10/01 18:00:08 chs Exp $   */
+/*     $NetBSD: if_hvn.c,v 1.6 2019/11/15 08:51:27 nonaka Exp $        */
 /*     $OpenBSD: if_hvn.c,v 1.39 2018/03/11 14:31:34 mikeb Exp $       */
 
 /*-
@@ -35,7 +35,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: if_hvn.c,v 1.5 2019/10/01 18:00:08 chs Exp $");
+__KERNEL_RCSID(0, "$NetBSD: if_hvn.c,v 1.6 2019/11/15 08:51:27 nonaka Exp $");
 
 #ifdef _KERNEL_OPT
 #include "opt_inet.h"
@@ -922,12 +922,6 @@
 
        sc->sc_chan->ch_flags &= ~CHF_BATCHED;
 
-       if (vmbus_channel_setdeferred(sc->sc_chan, device_xname(sc->sc_dev))) {
-               aprint_error_dev(sc->sc_dev,
-                   "failed to create the interrupt thread\n");
-               return -1;
-       }
-
        /* Associate our interrupt handler with the channel */
        if (vmbus_channel_open(sc->sc_chan, ringsize, NULL, 0,
            hvn_nvs_intr, sc)) {



Home | Main Index | Thread Index | Old Index