Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/external/bsd/compiler_rt/lib/clang/lib/netbsd clang: fix bui...



details:   https://anonhg.NetBSD.org/src/rev/1f8a32cb643e
branches:  trunk
changeset: 961460:1f8a32cb643e
user:      rillig <rillig%NetBSD.org@localhost>
date:      Tue Apr 20 23:19:53 2021 +0000

description:
clang: fix build for installing libclang_rt.ubsan_minimal-x86_64.a

The build failed with:

        --- install-ubsan_minimal-m64 ---
        x86_64--netbsd-install: the last argument
            (/.../libclang_rt.ubsan_minimal-x86_64.a.syms)
            must name an existing directory

The cause of this is that the suffix transformation rule for .a.a.sym
was active even during 'make install'.

At that point, the make variable .ALLSRC for the target
${DESTDIR}/.../libclang_rt.ubsan_minimal-x86_64.a.sym included not only
the corresponding file from the source directory, but also the potential
source file from the transformation rule, in this case
libclang_rt.ubsan_minimal-x86_64.a.

This led to several file parameters for the command 'install', which is
only allowed if the last parameter names an existing directory.

diffstat:

 external/bsd/compiler_rt/lib/clang/lib/netbsd/syms.mk |  4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diffs (18 lines):

diff -r 1bcf77d1622e -r 1f8a32cb643e external/bsd/compiler_rt/lib/clang/lib/netbsd/syms.mk
--- a/external/bsd/compiler_rt/lib/clang/lib/netbsd/syms.mk     Tue Apr 20 21:48:39 2021 +0000
+++ b/external/bsd/compiler_rt/lib/clang/lib/netbsd/syms.mk     Tue Apr 20 23:19:53 2021 +0000
@@ -1,7 +1,8 @@
-#      $NetBSD: syms.mk,v 1.3 2019/08/30 23:36:40 kamil Exp $
+#      $NetBSD: syms.mk,v 1.4 2021/04/20 23:19:53 rillig Exp $
 
 here := ${.PARSEDIR}
 
+.if !make(install)             # allow both .a and .a.syms to be installed
 .SUFFIXES: .a .a.syms
 .a.a.syms:
        ${_MKTARGET_CREATE}
@@ -10,3 +11,4 @@
                ${here}/gen_dynamic_list.sh \
                --extra ${SYMS_EXTRA:Q} \
                ${.IMPSRC} > ${.TARGET}
+.endif



Home | Main Index | Thread Index | Old Index