Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/dev/mca update comment about the 'quirk' in we_mca_init_...



details:   https://anonhg.NetBSD.org/src/rev/1ad58d03e094
branches:  trunk
changeset: 954418:1ad58d03e094
user:      jdolecek <jdolecek%NetBSD.org@localhost>
date:      Thu Apr 08 17:36:33 2021 +0000

description:
update comment about the 'quirk' in we_mca_init_hook() - actually that is
just interrupt enable bit, so not a quirk at all; NFCI

info passed by Valery Ushakov from a guy running https://www.os2museum.com/wp/

diffstat:

 sys/dev/mca/if_we_mca.c |  10 ++++------
 1 files changed, 4 insertions(+), 6 deletions(-)

diffs (32 lines):

diff -r 59f848423ee2 -r 1ad58d03e094 sys/dev/mca/if_we_mca.c
--- a/sys/dev/mca/if_we_mca.c   Thu Apr 08 15:06:50 2021 +0000
+++ b/sys/dev/mca/if_we_mca.c   Thu Apr 08 17:36:33 2021 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: if_we_mca.c,v 1.21 2008/04/28 20:23:53 martin Exp $    */
+/*     $NetBSD: if_we_mca.c,v 1.22 2021/04/08 17:36:33 jdolecek Exp $  */
 
 /*-
  * Copyright (c) 1997, 1998, 2001 The NetBSD Foundation, Inc.
@@ -53,7 +53,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: if_we_mca.c,v 1.21 2008/04/28 20:23:53 martin Exp $");
+__KERNEL_RCSID(0, "$NetBSD: if_we_mca.c,v 1.22 2021/04/08 17:36:33 jdolecek Exp $");
 
 #include <sys/param.h>
 #include <sys/systm.h>
@@ -302,11 +302,9 @@
 we_mca_init_hook(struct we_softc *wsc)
 {
        /*
-        * This quirk really needs to be here, at least for WD8003W/A. Without
-        * this, the card doesn't send any interrupts in 16bit mode. The quirk
+        * Enable interrupts. This is required for at least WD8003W/A, without
+        * this, the card doesn't send any interrupts in 16bit mode. The code
         * was taken from Linux smc-mca.c driver.
-        * I do not know why it's necessary. I don't want to know. It works
-        * and that is enough for me.
         */
        bus_space_write_1(wsc->sc_asict, wsc->sc_asich, WE_LAAR, 0x04);
        wsc->sc_laar_proto |= 0x04;



Home | Main Index | Thread Index | Old Index