Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/external/mpl/bind/dist/lib bind: remove workaround for bugs ...



details:   https://anonhg.NetBSD.org/src/rev/f6b6cb74ffab
branches:  trunk
changeset: 954333:f6b6cb74ffab
user:      rillig <rillig%NetBSD.org@localhost>
date:      Mon Apr 05 10:19:34 2021 +0000

description:
bind: remove workaround for bugs in lint

The bugs have been fixed in lint1/init.c 1.179 from 2021-03-30.

diffstat:

 external/mpl/bind/dist/lib/dns/peer.c        |  5 +----
 external/mpl/bind/dist/lib/isc/netmgr/udp.c  |  7 ++-----
 external/mpl/bind/dist/lib/isc/task.c        |  4 +---
 external/mpl/bind/dist/lib/ns/client.c       |  4 +---
 external/mpl/bind/dist/lib/ns/interfacemgr.c |  4 +---
 5 files changed, 6 insertions(+), 18 deletions(-)

diffs (113 lines):

diff -r c2b59e922f04 -r f6b6cb74ffab external/mpl/bind/dist/lib/dns/peer.c
--- a/external/mpl/bind/dist/lib/dns/peer.c     Mon Apr 05 07:28:19 2021 +0000
+++ b/external/mpl/bind/dist/lib/dns/peer.c     Mon Apr 05 10:19:34 2021 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: peer.c,v 1.6 2021/03/23 20:59:02 christos Exp $        */
+/*     $NetBSD: peer.c,v 1.7 2021/04/05 10:19:34 rillig Exp $  */
 
 /*
  * Copyright (C) Internet Systems Consortium, Inc. ("ISC")
@@ -215,8 +215,6 @@
        REQUIRE(peerptr != NULL && *peerptr == NULL);
 
        peer = isc_mem_get(mem, sizeof(*peer));
-
-#ifndef __lint__ // XXX: bug
        *peer = (dns_peer_t){
                .magic = DNS_PEER_MAGIC,
                .address = *addr,
@@ -224,7 +222,6 @@
                .mem = mem,
                .transfer_format = dns_one_answer,
        };
-#endif
 
        isc_refcount_init(&peer->refs, 1);
 
diff -r c2b59e922f04 -r f6b6cb74ffab external/mpl/bind/dist/lib/isc/netmgr/udp.c
--- a/external/mpl/bind/dist/lib/isc/netmgr/udp.c       Mon Apr 05 07:28:19 2021 +0000
+++ b/external/mpl/bind/dist/lib/isc/netmgr/udp.c       Mon Apr 05 10:19:34 2021 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: udp.c,v 1.5 2021/03/23 20:59:03 christos Exp $ */
+/*     $NetBSD: udp.c,v 1.6 2021/04/05 10:19:34 rillig Exp $   */
 
 /*
  * Copyright (C) Internet Systems Consortium, Inc. ("ISC")
@@ -543,10 +543,7 @@
 
        if (isc_nm_tid() == rsock->tid) {
                isc__netievent_udpsend_t ievent
-#ifndef __lint__ // XXX: bug
-               = { .sock = rsock, .req = uvreq, .peer = *peer }
-#endif
-               ;
+               = { .sock = rsock, .req = uvreq, .peer = *peer };
 
                isc__nm_async_udpsend(NULL, (isc__netievent_t *)&ievent);
        } else {
diff -r c2b59e922f04 -r f6b6cb74ffab external/mpl/bind/dist/lib/isc/task.c
--- a/external/mpl/bind/dist/lib/isc/task.c     Mon Apr 05 07:28:19 2021 +0000
+++ b/external/mpl/bind/dist/lib/isc/task.c     Mon Apr 05 10:19:34 2021 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: task.c,v 1.11 2021/03/23 20:59:03 christos Exp $       */
+/*     $NetBSD: task.c,v 1.12 2021/04/05 10:19:34 rillig Exp $ */
 
 /*
  * Copyright (C) Internet Systems Consortium, Inc. ("ISC")
@@ -1386,10 +1386,8 @@
        REQUIRE(managerp != NULL && *managerp == NULL);
 
        manager = isc_mem_get(mctx, sizeof(*manager));
-#ifndef __lint__ // XXX: bug
        *manager = (isc__taskmgr_t){ .common.impmagic = TASK_MANAGER_MAGIC,
                                     .common.magic = ISCAPI_TASKMGR_MAGIC };
-#endif
 
        atomic_store(&manager->mode, isc_taskmgrmode_normal);
        isc_mutex_init(&manager->lock);
diff -r c2b59e922f04 -r f6b6cb74ffab external/mpl/bind/dist/lib/ns/client.c
--- a/external/mpl/bind/dist/lib/ns/client.c    Mon Apr 05 07:28:19 2021 +0000
+++ b/external/mpl/bind/dist/lib/ns/client.c    Mon Apr 05 10:19:34 2021 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: client.c,v 1.13 2021/03/23 20:59:03 christos Exp $     */
+/*     $NetBSD: client.c,v 1.14 2021/04/05 10:19:34 rillig Exp $       */
 
 /*
  * Copyright (C) Internet Systems Consortium, Inc. ("ISC")
@@ -2311,7 +2311,6 @@
                 * Retain these values from the existing client, but
                 * zero every thing else.
                 */
-#ifndef __lint__ // XXX: bug
                *client = (ns_client_t){ .magic = 0,
                                         .mctx = oldmctx,
                                         .manager = oldmgr,
@@ -2320,7 +2319,6 @@
                                         .sendbuf = sendbuf,
                                         .message = message,
                                         .query = query };
-#endif
        }
 
        client->query.attributes &= ~NS_QUERYATTR_ANSWERED;
diff -r c2b59e922f04 -r f6b6cb74ffab external/mpl/bind/dist/lib/ns/interfacemgr.c
--- a/external/mpl/bind/dist/lib/ns/interfacemgr.c      Mon Apr 05 07:28:19 2021 +0000
+++ b/external/mpl/bind/dist/lib/ns/interfacemgr.c      Mon Apr 05 10:19:34 2021 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: interfacemgr.c,v 1.10 2021/03/23 20:59:03 christos Exp $       */
+/*     $NetBSD: interfacemgr.c,v 1.11 2021/04/05 10:19:34 rillig Exp $ */
 
 /*
  * Copyright (C) Internet Systems Consortium, Inc. ("ISC")
@@ -398,11 +398,9 @@
        REQUIRE(NS_INTERFACEMGR_VALID(mgr));
 
        ifp = isc_mem_get(mgr->mctx, sizeof(*ifp));
-#ifndef __lint__ // XXX: bug
        *ifp = (ns_interface_t){ .generation = mgr->generation,
                                 .addr = *addr,
                                 .dscp = -1 };
-#endif
 
        strlcpy(ifp->name, name, sizeof(ifp->name));
 



Home | Main Index | Thread Index | Old Index