[src/trunk]: src/usr.bin/make make: add a few open questions to Var_SetWithFlags

[rillig <rillig%NetBSD.org@localhost>]

details:   https://anonhg.NetBSD.org/src/rev/09ba566e332d
branches:  trunk
changeset: 952981:09ba566e332d
user:      rillig <rillig%NetBSD.org@localhost>
date:      Mon Feb 22 22:34:04 2021 +0000

description:
make: add a few open questions to Var_SetWithFlags

diffstat:

 usr.bin/make/var.c |  7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)

diffs (28 lines):

diff -r ca941057a3bb -r 09ba566e332d usr.bin/make/var.c
--- a/usr.bin/make/var.c        Mon Feb 22 22:26:50 2021 +0000
+++ b/usr.bin/make/var.c        Mon Feb 22 22:34:04 2021 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: var.c,v 1.835 2021/02/22 22:26:50 rillig Exp $ */
+/*     $NetBSD: var.c,v 1.836 2021/02/22 22:34:04 rillig Exp $ */
 
 /*
  * Copyright (c) 1988, 1989, 1990, 1993
@@ -140,7 +140,7 @@
 #include "metachar.h"
 
 /*     "@(#)var.c      8.3 (Berkeley) 3/19/94" */
-MAKE_RCSID("$NetBSD: var.c,v 1.835 2021/02/22 22:26:50 rillig Exp $");
+MAKE_RCSID("$NetBSD: var.c,v 1.836 2021/02/22 22:34:04 rillig Exp $");
 
 typedef enum VarFlags {
        VFL_NONE        = 0,
@@ -1020,6 +1020,9 @@
                 */
                if (!opts.varNoExportEnv)
                        setenv(name, val, 1);
+               /* XXX: What about .MAKE.EXPORTED? */
+               /* XXX: Why not just mark the variable for needing export,
+                *  as in ExportVarPlain? */
 
                Global_Append(MAKEOVERRIDES, name);
        }