[src/netbsd-8]: src/sys/arch/x86/x86 Pull up following revision(s) (requested...

[martin <martin%NetBSD.org@localhost>]

details:   https://anonhg.NetBSD.org/src/rev/1938cc477f71
branches:  netbsd-8
changeset: 952849:1938cc477f71
user:      martin <martin%NetBSD.org@localhost>
date:      Fri Feb 19 17:49:19 2021 +0000

description:
Pull up following revision(s) (requested by knakahara in ticket #1657):

        sys/arch/x86/x86/intr.c: revision 1.154 (via patch)

Fix x86's pci_intr_disestablish clean up routine.  Pointed out by t-kusaba@IIJ, thanks.

Fix panic on x86 by the following code.

====================
    sc_ih = pci_intr_establish_xname(sc_pc, ...);
    pci_intr_disestablish(sc_pc, sc_ih);
    sc_ih = pci_intr_establish(sc_pc, ...);
====================

ena(4) do such processing when ifconfig down/up.

XXX pullup-8,9

diffstat:

 sys/arch/x86/x86/intr.c |  13 ++++++++-----
 1 files changed, 8 insertions(+), 5 deletions(-)

diffs (44 lines):

diff -r 57129ac6e5bb -r 1938cc477f71 sys/arch/x86/x86/intr.c
--- a/sys/arch/x86/x86/intr.c   Wed Feb 17 09:56:53 2021 +0000
+++ b/sys/arch/x86/x86/intr.c   Fri Feb 19 17:49:19 2021 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: intr.c,v 1.101.2.7 2019/11/14 15:58:06 martin Exp $    */
+/*     $NetBSD: intr.c,v 1.101.2.8 2021/02/19 17:49:19 martin Exp $    */
 
 /*-
  * Copyright (c) 2007, 2008, 2009 The NetBSD Foundation, Inc.
@@ -133,7 +133,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: intr.c,v 1.101.2.7 2019/11/14 15:58:06 martin Exp $");
+__KERNEL_RCSID(0, "$NetBSD: intr.c,v 1.101.2.8 2021/02/19 17:49:19 martin Exp $");
 
 #include "opt_intrdebug.h"
 #include "opt_multiprocessor.h"
@@ -807,6 +807,9 @@
        ci->ci_isources[slot] = NULL;
        if (pic != &i8259_pic)
                idt_vec_free(idtvec);
+
+       isp->is_recurse = NULL;
+       isp->is_resume = NULL;
 }
 
 #ifdef MULTIPROCESSOR
@@ -1161,12 +1164,12 @@
        else
                (*pic->pic_hwunmask)(pic, ih->ih_pin);
 
+       /* If the source is free we can drop it now. */
+       intr_source_free(ci, ih->ih_slot, pic, idtvec);
+
        /* Re-enable interrupts. */
        x86_write_psl(psl);
 
-       /* If the source is free we can drop it now. */
-       intr_source_free(ci, ih->ih_slot, pic, idtvec);
-
        DPRINTF(("%s: remove slot %d (pic %s pin %d vec %d)\n",
            device_xname(ci->ci_dev), ih->ih_slot, pic->pic_name,
            ih->ih_pin, idtvec));