Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src-draft/trunk]: src/sys/net80211 Can not call ieee80211_sta_join() locked,...



details:   https://anonhg.NetBSD.org/src-all/rev/197ea91f4363
branches:  trunk
changeset: 952108:197ea91f4363
user:      Martin Husemann <martin%NetBSD.org@localhost>
date:      Mon Jul 06 20:06:00 2020 +0200

description:
Can not call ieee80211_sta_join() locked, it causes locking against
myself error on association.

diffstat:

 sys/net80211/ieee80211_ioctl.c |  2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diffs (13 lines):

diff -r ee20e44646d2 -r 197ea91f4363 sys/net80211/ieee80211_ioctl.c
--- a/sys/net80211/ieee80211_ioctl.c    Mon Jul 06 20:04:01 2020 +0200
+++ b/sys/net80211/ieee80211_ioctl.c    Mon Jul 06 20:06:00 2020 +0200
@@ -1731,9 +1731,7 @@
        if (lookup.se == NULL)
                return ENOENT;
        mlmedebug(vap, mac, IEEE80211_MLME_ASSOC, 0);
-       IEEE80211_LOCK(vap->iv_ic);
        int result = ieee80211_sta_join(vap, lookup.se->se_chan, lookup.se);
-       IEEE80211_UNLOCK(vap->iv_ic);
        if (!result)
                return EIO;             /* XXX unique but could be better */
        return 0;



Home | Main Index | Thread Index | Old Index