Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/usr.bin/make make(1): remove wrong comment from Var_Subst



details:   https://anonhg.NetBSD.org/src/rev/3e114842702a
branches:  trunk
changeset: 945717:3e114842702a
user:      rillig <rillig%NetBSD.org@localhost>
date:      Thu Nov 05 15:04:51 2020 +0000

description:
make(1): remove wrong comment from Var_Subst

The error handling in variable expressions is inconsistent.  Some errors
are detected, most aren't.  In particular, the error message for
undefined variables is _not_ issued on undefined variables but instead
on parse errors.

diffstat:

 usr.bin/make/var.c |  7 ++-----
 1 files changed, 2 insertions(+), 5 deletions(-)

diffs (28 lines):

diff -r 646eaeb2e0a5 -r 3e114842702a usr.bin/make/var.c
--- a/usr.bin/make/var.c        Thu Nov 05 13:04:27 2020 +0000
+++ b/usr.bin/make/var.c        Thu Nov 05 15:04:51 2020 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: var.c,v 1.657 2020/11/04 04:49:32 rillig Exp $ */
+/*     $NetBSD: var.c,v 1.658 2020/11/05 15:04:51 rillig Exp $ */
 
 /*
  * Copyright (c) 1988, 1989, 1990, 1993
@@ -130,7 +130,7 @@
 #include "metachar.h"
 
 /*     "@(#)var.c      8.3 (Berkeley) 3/19/94" */
-MAKE_RCSID("$NetBSD: var.c,v 1.657 2020/11/04 04:49:32 rillig Exp $");
+MAKE_RCSID("$NetBSD: var.c,v 1.658 2020/11/05 15:04:51 rillig Exp $");
 
 #define VAR_DEBUG1(fmt, arg1) DEBUG1(VAR, fmt, arg1)
 #define VAR_DEBUG2(fmt, arg1, arg2) DEBUG2(VAR, fmt, arg1, arg2)
@@ -3937,9 +3937,6 @@
 
 /* Substitute for all variables in the given string in the given context.
  *
- * If eflags & VARE_UNDEFERR, Parse_Error will be called when an undefined
- * variable is encountered.
- *
  * If eflags & VARE_WANTRES, any effects from the modifiers, such as ::=,
  * :sh or !cmd! take place.
  *



Home | Main Index | Thread Index | Old Index