Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/usr.sbin/npf/npftest/libnpftest npftest: Wait at least one t...



details:   https://anonhg.NetBSD.org/src/rev/d7c51f3bb450
branches:  trunk
changeset: 937833:d7c51f3bb450
user:      riastradh <riastradh%NetBSD.org@localhost>
date:      Thu Aug 27 18:51:20 2020 +0000

description:
npftest: Wait at least one tick in each gc busy wait iteration.

Otherwise the busy wait loop runs a little too fast for the gc about
half the times I run the test.

XXX We should really arrange mstohz to round up!

diffstat:

 usr.sbin/npf/npftest/libnpftest/npf_gc_test.c |  2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diffs (12 lines):

diff -r b3b902cde608 -r d7c51f3bb450 usr.sbin/npf/npftest/libnpftest/npf_gc_test.c
--- a/usr.sbin/npf/npftest/libnpftest/npf_gc_test.c     Thu Aug 27 18:50:25 2020 +0000
+++ b/usr.sbin/npf/npftest/libnpftest/npf_gc_test.c     Thu Aug 27 18:51:20 2020 +0000
@@ -222,7 +222,7 @@
                /* Wait for the task to be done. */
                while (!atomic_load_acquire(&task_done) && retry--) {
                        npf_worker_signal(test_npf);
-                       kpause("gctest", false, mstohz(1), NULL);
+                       kpause("gctest", false, MAX(1, mstohz(1)), NULL);
                }
 
                CHECK_TRUE(atomic_load_acquire(&task_done));



Home | Main Index | Thread Index | Old Index