Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/lib/libterminfo terminfo: test strlcpy result against space ...



details:   https://anonhg.NetBSD.org/src/rev/bcb9b004013f
branches:  trunk
changeset: 933759:bcb9b004013f
user:      roy <roy%NetBSD.org@localhost>
date:      Sat May 30 16:03:58 2020 +0000

description:
terminfo: test strlcpy result against space free, not string length

riastradh@ yep, looks good.

diffstat:

 lib/libterminfo/curterm.c |  14 +++++++-------
 1 files changed, 7 insertions(+), 7 deletions(-)

diffs (45 lines):

diff -r a4024ff35a9f -r bcb9b004013f lib/libterminfo/curterm.c
--- a/lib/libterminfo/curterm.c Sat May 30 15:55:47 2020 +0000
+++ b/lib/libterminfo/curterm.c Sat May 30 16:03:58 2020 +0000
@@ -1,4 +1,4 @@
-/* $NetBSD: curterm.c,v 1.13 2017/05/04 09:42:23 roy Exp $ */
+/* $NetBSD: curterm.c,v 1.14 2020/05/30 16:03:58 roy Exp $ */
 
 /*
  * Copyright (c) 2009, 2011 The NetBSD Foundation, Inc.
@@ -28,7 +28,7 @@
  */
 
 #include <sys/cdefs.h>
-__RCSID("$NetBSD: curterm.c,v 1.13 2017/05/04 09:42:23 roy Exp $");
+__RCSID("$NetBSD: curterm.c,v 1.14 2020/05/30 16:03:58 roy Exp $");
 
 #include <assert.h>
 #include <stdlib.h>
@@ -99,21 +99,21 @@
 
                p = ttytype;
                l = sizeof(ttytype);
-               if ((n = strlcpy(p, nterm->name, l)) == strlen(p)) {
+               if ((n = strlcpy(p, nterm->name, l)) < l) {
                        p += n;
                        l -= n;
                        *p++ = '|';
                        l--;
-                       if (nterm->_alias  &&
-                               (n = strlcpy(p, nterm->_alias, l)) == strlen(p))
+                       if (nterm->_alias != NULL &&
+                           (n = strlcpy(p, nterm->_alias, l)) < l)
                        {
                                p += n;
                                l -= n;
                                *p++ = '|';
                                l--;
                        }
-                       if (nterm->desc  &&
-                               (n = strlcpy(p, nterm->desc, l)) == strlen(p))
+                       if (nterm->desc != NULL &&
+                           (n = strlcpy(p, nterm->desc, l)) < l)
                        {
                                p += n;
                                l -= n;



Home | Main Index | Thread Index | Old Index