[pkgsrc/trunk]: pkgsrc/mk/tools mk/tools: don't create empty symlink for wron...

[rillig <rillig%pkgsrc.org@localhost>]

details:   https://anonhg.NetBSD.org/pkgsrc/rev/9a186c57bdb0
branches:  trunk
changeset: 431239:9a186c57bdb0
user:      rillig <rillig%pkgsrc.org@localhost>
date:      Sun May 10 14:36:18 2020 +0000

description:
mk/tools: don't create empty symlink for wrong tool definition

This case can only happen in the following special case:

TOOLS_CREATE+=          asdf
TOOLS_PATH.asdf=        # empty

If there is a lonely TOOLS_CREATE without a corresponding TOOLS_PATH, it
defaults to ${FALSE} and thus doesn't trigger this code.

diffstat:

 mk/tools/create.mk |  8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diffs (29 lines):

diff -r 1d60dda073ca -r 9a186c57bdb0 mk/tools/create.mk
--- a/mk/tools/create.mk        Sun May 10 14:27:46 2020 +0000
+++ b/mk/tools/create.mk        Sun May 10 14:36:18 2020 +0000
@@ -1,4 +1,4 @@
-# $NetBSD: create.mk,v 1.13 2020/05/09 21:08:05 rillig Exp $
+# $NetBSD: create.mk,v 1.14 2020/05/10 14:36:18 rillig Exp $
 #
 # Copyright (c) 2005, 2006 The NetBSD Foundation, Inc.
 # All rights reserved.
@@ -160,7 +160,9 @@
                logprefix='"set args$$shquoted_args; shift; "';         \
                logmain=${TOOLS_SCRIPT.${_t_}:Q:Q};                     \
                logsuffix='';                                           \
-       elif ${TEST} -n ${TOOLS_PATH.${_t_}:Q}""; then                  \
+       elif ${TEST} -z ${TOOLS_PATH.${_t_}:Q}""; then                  \
+               ${FAIL_MSG} "[mk/tools/create.mk] Invalid tool definition for ${_t_}"; \
+       else                                                            \
                if ${TEST} -n ${TOOLS_ARGS.${_t_}:Q}""; then            \
                        create=wrapper;                                 \
                        script=${TOOLS_SCRIPT_DFLT.${_t_}:Q};           \
@@ -177,8 +179,6 @@
                                logsuffix='$$shquoted_args';            \
                        esac;                                           \
                fi;                                                     \
-       else                                                            \
-               create=symlink;                                         \
        fi;                                                             \
        case "$$create" in                                              \
        wrapper)                                                        \