[src/trunk]: src/sys/net add a NOMPSAFE comment for if_mcast_op(), it is call...

[jdolecek <jdolecek%NetBSD.org@localhost>]

details:   https://anonhg.NetBSD.org/src/rev/b9873334d99f
branches:  trunk
changeset: 932334:b9873334d99f
user:      jdolecek <jdolecek%NetBSD.org@localhost>
date:      Tue May 05 09:22:24 2020 +0000

description:
add a NOMPSAFE comment for if_mcast_op(), it is called from context
which doesn't hold IFNET_LOCK() in some cases, and calls if_ioctl

this needs to be sorted out for NET_MPSAFE

diffstat:

 sys/net/if.c |  9 +++++++--
 1 files changed, 7 insertions(+), 2 deletions(-)

diffs (30 lines):

diff -r 112c05bd24db -r b9873334d99f sys/net/if.c
--- a/sys/net/if.c      Tue May 05 09:07:35 2020 +0000
+++ b/sys/net/if.c      Tue May 05 09:22:24 2020 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: if.c,v 1.475 2020/05/05 08:05:03 jdolecek Exp $        */
+/*     $NetBSD: if.c,v 1.476 2020/05/05 09:22:24 jdolecek Exp $        */
 
 /*-
  * Copyright (c) 1999, 2000, 2001, 2008 The NetBSD Foundation, Inc.
@@ -90,7 +90,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: if.c,v 1.475 2020/05/05 08:05:03 jdolecek Exp $");
+__KERNEL_RCSID(0, "$NetBSD: if.c,v 1.476 2020/05/05 09:22:24 jdolecek Exp $");
 
 #if defined(_KERNEL_OPT)
 #include "opt_inet.h"
@@ -3791,6 +3791,11 @@
        int rc;
        struct ifreq ifr;
 
+       /*
+        * XXX NOMPSAFE - this calls if_ioctl without holding IFNET_LOCK()
+        * in some cases - e.g. when called from vlan/netinet/netinet6 code
+        * directly rather than via sockopt/doifoictl()
+        */
        ifreq_setaddr(cmd, &ifr, sa);
        rc = (*ifp->if_ioctl)(ifp, cmd, &ifr);