[pkgsrc/trunk]: pkgsrc/games/7kaa games/7kaa: build even when CFLAGS has -Wer...

[rillig <rillig%pkgsrc.org@localhost>]

details:   https://anonhg.NetBSD.org/pkgsrc/rev/4be44b66dac4
branches:  trunk
changeset: 430710:4be44b66dac4
user:      rillig <rillig%pkgsrc.org@localhost>
date:      Sun May 03 14:22:43 2020 +0000

description:
games/7kaa: build even when CFLAGS has -Werror=char-subscripts

The upstream code looks very suspicious.  It forces compilation with
-fsigned-char and then uses signed characters to index a 256-entry table,
for example in IMGbltAreaRemap.  But only in the C++ code.
The corresponding assembler code uses unsigned bytes.
I'll let them fix this bug themselves.

diffstat:

 games/7kaa/Makefile |  6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)

diffs (20 lines):

diff -r 45aa03611e63 -r 4be44b66dac4 games/7kaa/Makefile
--- a/games/7kaa/Makefile       Sun May 03 13:14:21 2020 +0000
+++ b/games/7kaa/Makefile       Sun May 03 14:22:43 2020 +0000
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.10 2020/03/08 16:49:32 wiz Exp $
+# $NetBSD: Makefile,v 1.11 2020/05/03 14:22:43 rillig Exp $
 
 DISTNAME=      7kaa-2.15.3
 PKGREVISION=   3
@@ -29,6 +29,10 @@
 INSTALLATION_DIRS+=    share/applications
 INSTALLATION_DIRS+=    share/pixmaps
 
+# https://www.7kfans.com/forums/viewtopic.php?f=13&t=1150&p=8652
+# (bug report; requires login)
+BUILDLINK_TRANSFORM+=  rm:-Werror=char-subscripts
+
 post-extract:
        ${PREFIX}/bin/icotool -x -i 1 ${WRKSRC}/src/7k.ico -o ${WRKDIR}/7kaa.png