[pkgsrc/trunk]: pkgsrc/pkgtools/check-portability/files pkgtools/check-portab...

[rillig <rillig%pkgsrc.org@localhost>]

details:   https://anonhg.NetBSD.org/pkgsrc/rev/eacac97c7d40
branches:  trunk
changeset: 429390:eacac97c7d40
user:      rillig <rillig%pkgsrc.org@localhost>
date:      Sun Apr 19 12:47:27 2020 +0000

description:
pkgtools/check-portability: make test == an error

It had only been a warning before, due to a forgotten nerrors++. The
check in mk/check/check-portability.awk already treats this case as an
error.

diffstat:

 pkgtools/check-portability/files/check-portability.c |  4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diffs (25 lines):

diff -r abbff557f029 -r eacac97c7d40 pkgtools/check-portability/files/check-portability.c
--- a/pkgtools/check-portability/files/check-portability.c      Sun Apr 19 12:43:50 2020 +0000
+++ b/pkgtools/check-portability/files/check-portability.c      Sun Apr 19 12:47:27 2020 +0000
@@ -1,4 +1,4 @@
-/* $NetBSD: check-portability.c,v 1.13 2020/04/19 12:05:14 rillig Exp $ */
+/* $NetBSD: check-portability.c,v 1.14 2020/04/19 12:47:27 rillig Exp $ */
 
 /*
  Copyright (c) 2020 Roland Illig
@@ -389,6 +389,7 @@
        printf("%s:%zu:%zu: $RANDOM: %s\n",
            cstr_charptr(filename), lineno, idx + 1,
            cstr_charptr(line));
+       // No nerrors++ since this is not critical.
        explain(
            W_dollar_random,
            "The variable $RANDOM is not required for a POSIX-conforming shell, and",
@@ -437,6 +438,7 @@
            cstr_charptr(ad->filename), ad->lineno,
            (size_t) (f3.data - ad->line.data),
            cstr_charptr(ad->line));
+       nerrors++;
        explain(
            W_test_eqeq,
            "The \"test\" command, as well as the \"[\" command, are not required to know",