Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/dev/usb defer updating td actlen until we get acknowledg...



details:   https://anonhg.NetBSD.org/src/rev/80f5a3fecc97
branches:  trunk
changeset: 783859:80f5a3fecc97
user:      jmcneill <jmcneill%NetBSD.org@localhost>
date:      Thu Jan 10 21:25:53 2013 +0000

description:
defer updating td actlen until we get acknowledgement that the tx was successful, fixes umass writes (and probably a lot of other things)

diffstat:

 sys/dev/usb/dwc_otg.c |  6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diffs (34 lines):

diff -r df3a358d2e63 -r 80f5a3fecc97 sys/dev/usb/dwc_otg.c
--- a/sys/dev/usb/dwc_otg.c     Thu Jan 10 20:31:04 2013 +0000
+++ b/sys/dev/usb/dwc_otg.c     Thu Jan 10 21:25:53 2013 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: dwc_otg.c,v 1.2 2013/01/10 20:31:04 jmcneill Exp $     */
+/*     $NetBSD: dwc_otg.c,v 1.3 2013/01/10 21:25:53 jmcneill Exp $     */
 
 /*-
  * Copyright (c) 2012 Hans Petter Selasky. All rights reserved.
@@ -60,7 +60,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: dwc_otg.c,v 1.2 2013/01/10 20:31:04 jmcneill Exp $");
+__KERNEL_RCSID(0, "$NetBSD: dwc_otg.c,v 1.3 2013/01/10 21:25:53 jmcneill Exp $");
 
 #include <sys/param.h>
 #include <sys/systm.h>
@@ -3013,6 +3013,7 @@
                        if (!dwc_otg_host_channel_wait(td))
                                break;
 
+                       td->actlen += td->tx_bytes;
                        td->offset += td->tx_bytes;
                        td->remainder -= td->tx_bytes;
                        td->toggle ^= 1;
@@ -3159,7 +3160,6 @@
 
        /* store number of bytes transmitted */
        td->tx_bytes = count;
-       td->actlen += count;
        goto busy;
 
 send_cpkt:



Home | Main Index | Thread Index | Old Index