Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/arch/macppc/dev Fix issue with audio being downpitched, ...



details:   https://anonhg.NetBSD.org/src/rev/728a8794f48e
branches:  trunk
changeset: 829365:728a8794f48e
user:      sevan <sevan%NetBSD.org@localhost>
date:      Sat Jan 27 16:21:47 2018 +0000

description:
Fix issue with audio being downpitched, thanks to <nat>

"it seems that snapper_init should be called before audio_attach_mi, as snapper
init is setting the rate to 44100 after the hardware format has been configured
by audio_attach_mi.

audio_attach_mi should be the last thing called during an attach of an audio
device so the audio device is ready to be configured when audio_attach_mi is
called."

Resolves PR port-macppc/52949

diffstat:

 sys/arch/macppc/dev/snapper.c |  8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diffs (31 lines):

diff -r c338b73b855e -r 728a8794f48e sys/arch/macppc/dev/snapper.c
--- a/sys/arch/macppc/dev/snapper.c     Sat Jan 27 15:31:10 2018 +0000
+++ b/sys/arch/macppc/dev/snapper.c     Sat Jan 27 16:21:47 2018 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: snapper.c,v 1.41 2017/03/31 08:38:13 msaitoh Exp $     */
+/*     $NetBSD: snapper.c,v 1.42 2018/01/27 16:21:47 sevan Exp $       */
 /*     Id: snapper.c,v 1.11 2002/10/31 17:42:13 tsubai Exp     */
 /*     Id: i2s.c,v 1.12 2005/01/15 14:32:35 tsubai Exp         */
 
@@ -35,7 +35,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: snapper.c,v 1.41 2017/03/31 08:38:13 msaitoh Exp $");
+__KERNEL_RCSID(0, "$NetBSD: snapper.c,v 1.42 2018/01/27 16:21:47 sevan Exp $");
 
 #include <sys/param.h>
 #include <sys/audioio.h>
@@ -839,10 +839,10 @@
                break;
        }
 
-       audio_attach_mi(&snapper_hw_if, sc, sc->sc_dev);
-
        /* ki2c_setmode(sc->sc_i2c, I2C_STDSUBMODE); */
        snapper_init(sc, sc->sc_node);
+
+       audio_attach_mi(&snapper_hw_if, sc, sc->sc_dev);
 }
 
 static int



Home | Main Index | Thread Index | Old Index