Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/dev/pcmcia Fix memory leak, looks like there is still so...



details:   https://anonhg.NetBSD.org/src/rev/3cbae8ea139a
branches:  trunk
changeset: 829221:3cbae8ea139a
user:      maxv <maxv%NetBSD.org@localhost>
date:      Mon Jan 22 14:40:53 2018 +0000

description:
Fix memory leak, looks like there is still something wrong here.

diffstat:

 sys/dev/pcmcia/if_malo_pcmcia.c |  10 +++++++---
 1 files changed, 7 insertions(+), 3 deletions(-)

diffs (32 lines):

diff -r 8740839eca54 -r 3cbae8ea139a sys/dev/pcmcia/if_malo_pcmcia.c
--- a/sys/dev/pcmcia/if_malo_pcmcia.c   Mon Jan 22 13:29:28 2018 +0000
+++ b/sys/dev/pcmcia/if_malo_pcmcia.c   Mon Jan 22 14:40:53 2018 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: if_malo_pcmcia.c,v 1.15 2017/10/23 09:24:34 msaitoh Exp $      */
+/*     $NetBSD: if_malo_pcmcia.c,v 1.16 2018/01/22 14:40:53 maxv Exp $ */
 /*      $OpenBSD: if_malo.c,v 1.65 2009/03/29 21:53:53 sthen Exp $ */
 
 /*
@@ -18,7 +18,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: if_malo_pcmcia.c,v 1.15 2017/10/23 09:24:34 msaitoh Exp $");
+__KERNEL_RCSID(0, "$NetBSD: if_malo_pcmcia.c,v 1.16 2018/01/22 14:40:53 maxv Exp $");
 
 #ifdef _MODULE
 #include <sys/module.h>
@@ -1053,8 +1053,12 @@
        }
 
        /* push the frame up to the network stack if not in monitor mode */
-       if (ic->ic_opmode != IEEE80211_M_MONITOR)
+       if (ic->ic_opmode != IEEE80211_M_MONITOR) {
                if_percpuq_enqueue(ifp->if_percpuq, m);
+       } else {
+               /* XXX: we don't do anything with it? */
+               m_freem(m);
+       }
 }
 
 static int



Home | Main Index | Thread Index | Old Index