[src/trunk]: src/sys/netmpls Add XXX.

[maxv <maxv%NetBSD.org@localhost>]

details:   https://anonhg.NetBSD.org/src/rev/54ef06941295
branches:  trunk
changeset: 829150:54ef06941295
user:      maxv <maxv%NetBSD.org@localhost>
date:      Fri Jan 19 14:15:35 2018 +0000

description:
Add XXX.

diffstat:

 sys/netmpls/mpls_ttl.c |  12 ++++++++----
 1 files changed, 8 insertions(+), 4 deletions(-)

diffs (40 lines):

diff -r 6d39539d5e91 -r 54ef06941295 sys/netmpls/mpls_ttl.c
--- a/sys/netmpls/mpls_ttl.c    Fri Jan 19 13:17:29 2018 +0000
+++ b/sys/netmpls/mpls_ttl.c    Fri Jan 19 14:15:35 2018 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: mpls_ttl.c,v 1.10 2018/01/19 10:54:31 maxv Exp $ */
+/*     $NetBSD: mpls_ttl.c,v 1.11 2018/01/19 14:15:35 maxv Exp $ */
 
 /*
  * Copyright (c) 2010 The NetBSD Foundation, Inc.
@@ -97,7 +97,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: mpls_ttl.c,v 1.10 2018/01/19 10:54:31 maxv Exp $");
+__KERNEL_RCSID(0, "$NetBSD: mpls_ttl.c,v 1.11 2018/01/19 14:15:35 maxv Exp $");
 
 #ifdef _KERNEL_OPT
 #include "opt_inet.h"
@@ -147,7 +147,11 @@
  * Send an ICMP Extended error message. References: RFC4884 and RFC4950.
  *
  * This should be in sync with icmp_error() in sys/netinet/ip_icmp.c
- * XXX: is called only for ICMP_TIMXCEED_INTRANS but code is too general
+ * XXX: is called only for ICMP_TIMXCEED_INTRANS but code is too general.
+ *
+ * XXX We're not setting the 'length' field of the Extended ICMP header.
+ * According to RFC4884, we are in 'non-compliant' mode. Moreover, we're
+ * not computing the checksum of the Extended ICMP header.
  */
 static void
 mpls_icmp_error(struct mbuf *n, int type, int code, n_long dest,
@@ -162,7 +166,7 @@
 
        memset(&mpls_icmp_ext, 0, sizeof(mpls_icmp_ext));
        mpls_icmp_ext.cmn_hdr.version = ICMP_EXT_VERSION;
-       mpls_icmp_ext.cmn_hdr.checksum = 0;
+       mpls_icmp_ext.cmn_hdr.checksum = 0; /* XXX */
 
        mpls_icmp_ext.obj_hdr.length = htons(sizeof(union mpls_shim) +
            sizeof(struct icmp_ext_obj_hdr));