Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/ufs/ufs Amplify that even if we fixed it now the tentacl...



details:   https://anonhg.NetBSD.org/src/rev/5b54ead25a26
branches:  trunk
changeset: 807194:5b54ead25a26
user:      riastradh <riastradh%NetBSD.org@localhost>
date:      Tue Mar 31 11:43:05 2015 +0000

description:
Amplify that even if we fixed it now the tentacles are still stuck.

diffstat:

 sys/ufs/ufs/ufs_readwrite.c |  9 +++++++--
 1 files changed, 7 insertions(+), 2 deletions(-)

diffs (30 lines):

diff -r 783d53fe8b0b -r 5b54ead25a26 sys/ufs/ufs/ufs_readwrite.c
--- a/sys/ufs/ufs/ufs_readwrite.c       Tue Mar 31 09:26:45 2015 +0000
+++ b/sys/ufs/ufs/ufs_readwrite.c       Tue Mar 31 11:43:05 2015 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: ufs_readwrite.c,v 1.117 2015/03/31 00:22:50 riastradh Exp $    */
+/*     $NetBSD: ufs_readwrite.c,v 1.118 2015/03/31 11:43:05 riastradh Exp $    */
 
 /*-
  * Copyright (c) 1993
@@ -32,7 +32,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(1, "$NetBSD: ufs_readwrite.c,v 1.117 2015/03/31 00:22:50 riastradh Exp $");
+__KERNEL_RCSID(1, "$NetBSD: ufs_readwrite.c,v 1.118 2015/03/31 11:43:05 riastradh Exp $");
 
 #ifdef LFS_READWRITE
 #define        FS                      struct lfs
@@ -349,6 +349,11 @@
         * genfs_getpages/putpages to cope with the possibility that
         * the transaction may or may not be locked on entry to the
         * page cache.
+        *
+        * And even if we added that notion to WAPBL, it wouldn't help
+        * us get rid of the tentacles in genfs_getpages/putpages
+        * because we'd have to interoperate with old implementations
+        * that assume they can replay the log without fsck.
         */
        error = UFS_WAPBL_BEGIN(vp->v_mount);
        if (error) {



Home | Main Index | Thread Index | Old Index