Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/jdolecek-ncq]: src/sys/dev/ata atastart() rechecked - it's okay to call ...



details:   https://anonhg.NetBSD.org/src/rev/8c5395750ed4
branches:  jdolecek-ncq
changeset: 823016:8c5395750ed4
user:      jdolecek <jdolecek%NetBSD.org@localhost>
date:      Mon Sep 11 22:30:05 2017 +0000

description:
atastart() rechecked - it's okay to call it even in error path in those
several cases we do, it's just optimization to skip the call; I'm not even
very convinced it's useful to have this conditional, but keeping for now
until proven harmful

diffstat:

 sys/dev/ata/TODO.ncq |  5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)

diffs (15 lines):

diff -r 82d5932aa479 -r 8c5395750ed4 sys/dev/ata/TODO.ncq
--- a/sys/dev/ata/TODO.ncq      Mon Sep 11 22:19:23 2017 +0000
+++ b/sys/dev/ata/TODO.ncq      Mon Sep 11 22:30:05 2017 +0000
@@ -2,11 +2,6 @@
 ----
 test wd* at umass?, confirm the ata_channel kludge works
 
-revise calls to atastart() - now called alsoafter ATASTART_ABORT(), call
-only from intr routine
-- wdc.c never calls atastart() (start always false)
-- ata_wdc.c calls atastart() regardless if error
-
 reconsider freeze/thaw in error recovery - can it screw up with thread?
 
 Other random notes (do outside the NCQ branch):



Home | Main Index | Thread Index | Old Index