Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/jdolecek-ncqfixes]: src/sys/dev/ata add comment to kthread_create() call...



details:   https://anonhg.NetBSD.org/src/rev/bc5b731924d1
branches:  jdolecek-ncqfixes
changeset: 850603:bc5b731924d1
user:      jdolecek <jdolecek%NetBSD.org@localhost>
date:      Sun Oct 14 16:13:51 2018 +0000

description:
add comment to kthread_create() call to explain why atabus_thread is actually
running under KERNEL_LOCK()

diffstat:

 sys/dev/ata/ata.c |  5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diffs (26 lines):

diff -r fa6afe1ff9a0 -r bc5b731924d1 sys/dev/ata/ata.c
--- a/sys/dev/ata/ata.c Sun Oct 14 14:50:54 2018 +0000
+++ b/sys/dev/ata/ata.c Sun Oct 14 16:13:51 2018 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: ata.c,v 1.141.6.16 2018/10/11 20:57:51 jdolecek Exp $  */
+/*     $NetBSD: ata.c,v 1.141.6.17 2018/10/14 16:13:51 jdolecek Exp $  */
 
 /*
  * Copyright (c) 1998, 2001 Manuel Bouyer.  All rights reserved.
@@ -25,7 +25,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: ata.c,v 1.141.6.16 2018/10/11 20:57:51 jdolecek Exp $");
+__KERNEL_RCSID(0, "$NetBSD: ata.c,v 1.141.6.17 2018/10/14 16:13:51 jdolecek Exp $");
 
 #include "opt_ata.h"
 
@@ -593,6 +593,7 @@
        mutex_exit(&atabus_qlock);
        config_pending_incr(sc->sc_dev);
 
+       /* XXX MPSAFE - no KTHREAD_MPSAFE, so protected by KERNEL_LOCK() */
        if ((error = kthread_create(PRI_NONE, 0, NULL, atabus_thread, sc,
            &chp->ch_thread, "%s", device_xname(self))) != 0)
                aprint_error_dev(self,



Home | Main Index | Thread Index | Old Index