[src/trunk]: src/sys/netinet PR/49676: Ryo Shimizu: ICMP_STATINC() buffer ove...

[christos <christos%NetBSD.org@localhost>]

details:   https://anonhg.NetBSD.org/src/rev/f7d000af8d87
branches:  trunk
changeset: 806361:f7d000af8d87
user:      christos <christos%NetBSD.org@localhost>
date:      Wed Feb 18 17:00:15 2015 +0000

description:
PR/49676: Ryo Shimizu: ICMP_STATINC() buffer overflows
XXX: pullup-7

diffstat:

 sys/netinet/icmp_var.h |  6 +++---
 sys/netinet/ip_icmp.h  |  3 ++-
 2 files changed, 5 insertions(+), 4 deletions(-)

diffs (37 lines):

diff -r 468d8adc407a -r f7d000af8d87 sys/netinet/icmp_var.h
--- a/sys/netinet/icmp_var.h    Wed Feb 18 16:47:58 2015 +0000
+++ b/sys/netinet/icmp_var.h    Wed Feb 18 17:00:15 2015 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: icmp_var.h,v 1.29 2011/12/24 19:54:41 christos Exp $   */
+/*     $NetBSD: icmp_var.h,v 1.30 2015/02/18 17:00:15 christos Exp $   */
 
 /*
  * Copyright (c) 1982, 1986, 1993
@@ -56,8 +56,8 @@
 #define        ICMP_STAT_BMCASTTSTAMP  10      /* b/mcast tstamp requests dropped */
 #define        ICMP_STAT_LAST          16      /* Allow for 5 spare ones */
 #define        ICMP_STAT_OUTHIST       ICMP_STAT_LAST
-#define        ICMP_STAT_INHIST        (ICMP_STAT_LAST + ICMP_MAXTYPE)
-#define        ICMP_NSTATS             (ICMP_STAT_LAST + 2 * ICMP_MAXTYPE)
+#define        ICMP_STAT_INHIST        (ICMP_STAT_LAST + ICMP_NTYPES)
+#define        ICMP_NSTATS             (ICMP_STAT_LAST + 2 * ICMP_NTYPES)
 
 /*
  * Names for ICMP sysctl objects
diff -r 468d8adc407a -r f7d000af8d87 sys/netinet/ip_icmp.h
--- a/sys/netinet/ip_icmp.h     Wed Feb 18 16:47:58 2015 +0000
+++ b/sys/netinet/ip_icmp.h     Wed Feb 18 17:00:15 2015 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: ip_icmp.h,v 1.33 2011/12/24 20:18:54 christos Exp $    */
+/*     $NetBSD: ip_icmp.h,v 1.34 2015/02/18 17:00:15 christos Exp $    */
 
 /*
  * Copyright (c) 1982, 1986, 1993
@@ -189,6 +189,7 @@
 #define                ICMP_PHOTURIS_NEED_AUTHZ        5       /* no authorization */
 
 #define ICMP_MAXTYPE           40
+#define ICMP_NTYPES            (ICMP_MAXTYPE + 1)
 
 #ifdef ICMP_STRINGS
 static const char *icmp_type[] = {