Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/netbsd-7]: src/sys/dev/ic Pull up following revision(s) (requested by ha...



details:   https://anonhg.NetBSD.org/src/rev/fa548787bf8b
branches:  netbsd-7
changeset: 799518:fa548787bf8b
user:      snj <snj%NetBSD.org@localhost>
date:      Thu Jul 30 15:53:39 2015 +0000

description:
Pull up following revision(s) (requested by hannken in ticket #910):
        sys/dev/ic/mpt_netbsd.c: revision 1.32
Adapter leaks requests when mpt_event_notify_reply() has to acknowledge
an event leading to "adapter resource shortage" messages when the scsipi
subsystem tries to use all adapt_openings.
Change mpt_ctlop() to free the request on event MPI_FUNCTION_EVENT_ACK.
Tested on a SunFire X4275 with Symbios Logic SAS1068E (1000:0058, rev. 4).

diffstat:

 sys/dev/ic/mpt_netbsd.c |  12 ++++++++++--
 1 files changed, 10 insertions(+), 2 deletions(-)

diffs (35 lines):

diff -r fb1da4aa380d -r fa548787bf8b sys/dev/ic/mpt_netbsd.c
--- a/sys/dev/ic/mpt_netbsd.c   Thu Jul 30 15:51:58 2015 +0000
+++ b/sys/dev/ic/mpt_netbsd.c   Thu Jul 30 15:53:39 2015 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: mpt_netbsd.c,v 1.25.2.1 2014/09/29 16:15:58 msaitoh Exp $      */
+/*     $NetBSD: mpt_netbsd.c,v 1.25.2.2 2015/07/30 15:53:39 snj Exp $  */
 
 /*
  * Copyright (c) 2003 Wasabi Systems, Inc.
@@ -77,7 +77,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: mpt_netbsd.c,v 1.25.2.1 2014/09/29 16:15:58 msaitoh Exp $");
+__KERNEL_RCSID(0, "$NetBSD: mpt_netbsd.c,v 1.25.2.2 2015/07/30 15:53:39 snj Exp $");
 
 #include "bio.h"
 
@@ -1270,8 +1270,16 @@
                break;
 
        case MPI_FUNCTION_EVENT_ACK:
+           {
+               MSG_EVENT_ACK_REPLY *msg = vmsg;
+               int index = le32toh(msg->MsgContext) & ~0x80000000;
                mpt_free_reply(mpt, (reply << 1));
+               if (index >= 0 && index < MPT_MAX_REQUESTS(mpt)) {
+                       request_t *req = &mpt->request_pool[index];
+                       mpt_free_request(mpt, req);
+               }
                break;
+           }
 
        case MPI_FUNCTION_PORT_ENABLE:
            {



Home | Main Index | Thread Index | Old Index