Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/dev/pci/ixgbe The rx_bytes event counter is cleared when...



details:   https://anonhg.NetBSD.org/src/rev/b20ea2c3d666
branches:  trunk
changeset: 819751:b20ea2c3d666
user:      msaitoh <msaitoh%NetBSD.org@localhost>
date:      Fri Dec 16 08:24:40 2016 +0000

description:
The rx_bytes event counter is cleared when if_init() is called, but not for
rx_packets. It's inconsistent. It makes rx_packets is bigger than rx_bytes.
IMHO, it's not required to clear them. At least the above comment says
"/* Setup our descriptor indices */". It's not descriptor indice...

diffstat:

 sys/dev/pci/ixgbe/ix_txrx.c |  7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)

diffs (25 lines):

diff -r 895aca3d8986 -r b20ea2c3d666 sys/dev/pci/ixgbe/ix_txrx.c
--- a/sys/dev/pci/ixgbe/ix_txrx.c       Fri Dec 16 06:29:11 2016 +0000
+++ b/sys/dev/pci/ixgbe/ix_txrx.c       Fri Dec 16 08:24:40 2016 +0000
@@ -59,7 +59,7 @@
  * POSSIBILITY OF SUCH DAMAGE.
  */
 /*$FreeBSD: head/sys/dev/ixgbe/ix_txrx.c 301538 2016-06-07 04:51:50Z sephe $*/
-/*$NetBSD: ix_txrx.c,v 1.12 2016/12/15 09:28:05 ozaki-r Exp $*/
+/*$NetBSD: ix_txrx.c,v 1.13 2016/12/16 08:24:40 msaitoh Exp $*/
 
 #include "opt_inet.h"
 #include "opt_inet6.h"
@@ -1573,7 +1573,12 @@
        rxr->next_to_refresh = 0;
        rxr->lro_enabled = FALSE;
        rxr->rx_copies.ev_count = 0;
+#if 0 /* NetBSD */
        rxr->rx_bytes.ev_count = 0;
+#if 1  /* Fix inconsistency */
+       rxr->rx_packets.ev_count = 0;
+#endif
+#endif
        rxr->vtag_strip = FALSE;
 
        ixgbe_dmamap_sync(rxr->rxdma.dma_tag, rxr->rxdma.dma_map,



Home | Main Index | Thread Index | Old Index