Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/dev/pci/n8 Delete bogus NULL test.



details:   https://anonhg.NetBSD.org/src/rev/d546950cf5b9
branches:  trunk
changeset: 827036:d546950cf5b9
user:      maya <maya%NetBSD.org@localhost>
date:      Mon Oct 09 23:42:40 2017 +0000

description:
Delete bogus NULL test.

We deref session just above, and all callers already have session != NULL
already.

suggested by riastradh, spotted by coccinelle

diffstat:

 sys/dev/pci/n8/nsp.c |  6 ------
 1 files changed, 0 insertions(+), 6 deletions(-)

diffs (16 lines):

diff -r acbb49566ade -r d546950cf5b9 sys/dev/pci/n8/nsp.c
--- a/sys/dev/pci/n8/nsp.c      Mon Oct 09 23:24:22 2017 +0000
+++ b/sys/dev/pci/n8/nsp.c      Mon Oct 09 23:42:40 2017 +0000
@@ -701,12 +701,6 @@
        }
 
        mutex_enter(&sc->sc_intrlock);
-       if (session == NULL) {
-               DBG(("n8_session_free: attempt to free NULL\n"));
-               mutex_exit(&sc->sc_intrlock);
-               return;
-       }
-
        session->next = sc->freesession;
        sc->freesession = session;
        session->magic = 0xFEED;



Home | Main Index | Thread Index | Old Index