[src/trunk]: src/sys/ufs/lfs XXX question our double-flushing of dirops

[maya <maya%NetBSD.org@localhost>]

details:   https://anonhg.NetBSD.org/src/rev/6f5aeb7179ad
branches:  trunk
changeset: 826179:6f5aeb7179ad
user:      maya <maya%NetBSD.org@localhost>
date:      Sun Aug 20 00:03:12 2017 +0000

description:
XXX question our double-flushing of dirops

diffstat:

 sys/ufs/lfs/lfs_segment.c |  10 +++++++---
 1 files changed, 7 insertions(+), 3 deletions(-)

diffs (31 lines):

diff -r e64e71306d0b -r 6f5aeb7179ad sys/ufs/lfs/lfs_segment.c
--- a/sys/ufs/lfs/lfs_segment.c Sat Aug 19 21:18:47 2017 +0000
+++ b/sys/ufs/lfs/lfs_segment.c Sun Aug 20 00:03:12 2017 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: lfs_segment.c,v 1.274 2017/07/26 16:42:37 maya Exp $   */
+/*     $NetBSD: lfs_segment.c,v 1.275 2017/08/20 00:03:12 maya Exp $   */
 
 /*-
  * Copyright (c) 1999, 2000, 2001, 2002, 2003 The NetBSD Foundation, Inc.
@@ -60,7 +60,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: lfs_segment.c,v 1.274 2017/07/26 16:42:37 maya Exp $");
+__KERNEL_RCSID(0, "$NetBSD: lfs_segment.c,v 1.275 2017/08/20 00:03:12 maya Exp $");
 
 #ifdef DEBUG
 # define vndebug(vp, str) do {                                         \
@@ -661,7 +661,11 @@
                                error = lfs_writevnodes(fs, mp, sp, VN_DIROP);
                                if (um_error == 0)
                                        um_error = error;
-                               /* In case writevnodes errored out */
+                               /*
+                                * In case writevnodes errored out
+                                * XXX why are we always doing this and not
+                                * just on error?
+                                */
                                lfs_flush_dirops(fs);
                                ssp = (SEGSUM *)(sp->segsum);
                                lfs_ss_setflags(fs, ssp,