Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/kern PR/48098: Brian Marcotte: panic: kernel diagnostic ...



details:   https://anonhg.NetBSD.org/src/rev/c9ba3f4ad469
branches:  trunk
changeset: 791063:c9ba3f4ad469
user:      christos <christos%NetBSD.org@localhost>
date:      Sat Nov 02 20:09:33 2013 +0000

description:
PR/48098: Brian Marcotte: panic: kernel diagnostic assertion "cred != NULL":
Fix from Michael van Elst, tcpdrop crashes kernel on ebryonic connections.

diffstat:

 sys/kern/uipc_socket.c |  6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diffs (27 lines):

diff -r 6eae48983bda -r c9ba3f4ad469 sys/kern/uipc_socket.c
--- a/sys/kern/uipc_socket.c    Sat Nov 02 20:01:02 2013 +0000
+++ b/sys/kern/uipc_socket.c    Sat Nov 02 20:09:33 2013 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: uipc_socket.c,v 1.219 2013/10/17 20:57:06 christos Exp $       */
+/*     $NetBSD: uipc_socket.c,v 1.220 2013/11/02 20:09:33 christos Exp $       */
 
 /*-
  * Copyright (c) 2002, 2007, 2008, 2009 The NetBSD Foundation, Inc.
@@ -63,7 +63,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: uipc_socket.c,v 1.219 2013/10/17 20:57:06 christos Exp $");
+__KERNEL_RCSID(0, "$NetBSD: uipc_socket.c,v 1.220 2013/11/02 20:09:33 christos Exp $");
 
 #include "opt_compat_netbsd.h"
 #include "opt_sock_counters.h"
@@ -416,7 +416,7 @@
                /* Normal users can only drop their own connections. */
                struct socket *so = (struct socket *)arg1;
 
-               if (proc_uidmatch(cred, so->so_cred) == 0)
+               if (so->so_cred && proc_uidmatch(cred, so->so_cred) == 0)
                        result = KAUTH_RESULT_ALLOW;
 
                break;



Home | Main Index | Thread Index | Old Index