Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/net80211 ieee80211 users in Other OS export rssi and noi...



details:   https://anonhg.NetBSD.org/src/rev/117815f3753d
branches:  trunk
changeset: 814744:117815f3753d
user:      roy <roy%NetBSD.org@localhost>
date:      Wed Apr 06 14:42:16 2016 +0000

description:
ieee80211 users in Other OS export rssi and noise as int8_t.
We should not be the odd one out for no good reason and the majority
of the ieee80211 drivers treat rssi as int8_t.

diffstat:

 sys/net80211/ieee80211_ioctl.h    |   8 ++++----
 sys/net80211/ieee80211_node.c     |  14 +++++++-------
 sys/net80211/ieee80211_node.h     |   6 +++---
 sys/net80211/ieee80211_rssadapt.h |   4 ++--
 sys/net80211/ieee80211_var.h      |   4 ++--
 5 files changed, 18 insertions(+), 18 deletions(-)

diffs (152 lines):

diff -r 7c7b8d6da890 -r 117815f3753d sys/net80211/ieee80211_ioctl.h
--- a/sys/net80211/ieee80211_ioctl.h    Wed Apr 06 11:07:58 2016 +0000
+++ b/sys/net80211/ieee80211_ioctl.h    Wed Apr 06 14:42:16 2016 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: ieee80211_ioctl.h,v 1.21 2015/09/06 06:01:01 dholland Exp $    */
+/*     $NetBSD: ieee80211_ioctl.h,v 1.22 2016/04/06 14:42:16 roy Exp $ */
 /*-
  * Copyright (c) 2001 Atsushi Onoe
  * Copyright (c) 2002-2005 Sam Leffler, Errno Consulting
@@ -356,7 +356,7 @@
        u_int16_t       isi_flags;              /* channel flags */
        u_int16_t       isi_state;              /* state flags */
        u_int8_t        isi_authmode;           /* authentication algorithm */
-       u_int8_t        isi_rssi;
+       int8_t          isi_rssi;
        u_int8_t        isi_capinfo;            /* capabilities */
        u_int8_t        isi_erp;                /* ERP element */
        u_int8_t        isi_macaddr[IEEE80211_ADDR_LEN];
@@ -524,8 +524,8 @@
        u_int16_t       isr_len;                /* length (mult of 4) */
        u_int16_t       isr_freq;               /* MHz */
        u_int16_t       isr_flags;              /* channel flags */
-       u_int8_t        isr_noise;
-       u_int8_t        isr_rssi;
+       int8_t          isr_noise;
+       int8_t          isr_rssi;
        u_int8_t        isr_intval;             /* beacon interval */
        u_int8_t        isr_capinfo;            /* capabilities */
        u_int8_t        isr_erp;                /* ERP element */
diff -r 7c7b8d6da890 -r 117815f3753d sys/net80211/ieee80211_node.c
--- a/sys/net80211/ieee80211_node.c     Wed Apr 06 11:07:58 2016 +0000
+++ b/sys/net80211/ieee80211_node.c     Wed Apr 06 14:42:16 2016 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: ieee80211_node.c,v 1.69 2015/08/24 22:21:26 pooka Exp $        */
+/*     $NetBSD: ieee80211_node.c,v 1.70 2016/04/06 14:42:16 roy Exp $  */
 /*-
  * Copyright (c) 2001 Atsushi Onoe
  * Copyright (c) 2002-2005 Sam Leffler, Errno Consulting
@@ -36,7 +36,7 @@
 __FBSDID("$FreeBSD: src/sys/net80211/ieee80211_node.c,v 1.65 2005/08/13 17:50:21 sam Exp $");
 #endif
 #ifdef __NetBSD__
-__KERNEL_RCSID(0, "$NetBSD: ieee80211_node.c,v 1.69 2015/08/24 22:21:26 pooka Exp $");
+__KERNEL_RCSID(0, "$NetBSD: ieee80211_node.c,v 1.70 2016/04/06 14:42:16 roy Exp $");
 #endif
 
 #ifdef _KERNEL_OPT
@@ -85,7 +85,7 @@
 static struct ieee80211_node *node_alloc(struct ieee80211_node_table *);
 static void node_cleanup(struct ieee80211_node *);
 static void node_free(struct ieee80211_node *);
-static u_int8_t node_getrssi(const struct ieee80211_node *);
+static int8_t node_getrssi(const struct ieee80211_node *);
 
 static void ieee80211_setup_node(struct ieee80211_node_table *,
                struct ieee80211_node *, const u_int8_t *);
@@ -589,7 +589,7 @@
                       const struct ieee80211_node *b)
 {
        u_int8_t maxa, maxb;
-       u_int8_t rssia, rssib;
+       int8_t rssia, rssib;
        int weight;
 
        /* privacy support preferred */
@@ -1001,7 +1001,7 @@
        free(ni, M_80211_NODE);
 }
 
-static u_int8_t
+static int8_t
 node_getrssi(const struct ieee80211_node *ni)
 {
        return ni->ni_rssi;
@@ -2347,12 +2347,12 @@
                ieee80211_free_node(ni);
 }
 
-u_int8_t
+int8_t
 ieee80211_getrssi(struct ieee80211com *ic)
 {
 #define        NZ(x)   ((x) == 0 ? 1 : (x))
        struct ieee80211_node_table *nt = &ic->ic_sta;
-       u_int32_t rssi_samples, rssi_total;
+       int32_t rssi_samples, rssi_total;
        struct ieee80211_node *ni;
 
        rssi_total = 0;
diff -r 7c7b8d6da890 -r 117815f3753d sys/net80211/ieee80211_node.h
--- a/sys/net80211/ieee80211_node.h     Wed Apr 06 11:07:58 2016 +0000
+++ b/sys/net80211/ieee80211_node.h     Wed Apr 06 14:42:16 2016 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: ieee80211_node.h,v 1.25 2014/10/18 08:33:29 snj Exp $  */
+/*     $NetBSD: ieee80211_node.h,v 1.26 2016/04/06 14:42:16 roy Exp $  */
 /*-
  * Copyright (c) 2001 Atsushi Onoe
  * Copyright (c) 2002-2005 Sam Leffler, Errno Consulting
@@ -120,7 +120,7 @@
 
        /* hardware */
        u_int32_t               ni_rstamp;      /* recv timestamp */
-       u_int8_t                ni_rssi;        /* recv ssi */
+       int8_t                  ni_rssi;        /* recv ssi */
 
        /* header */
        u_int8_t                ni_macaddr[IEEE80211_ADDR_LEN];
@@ -286,7 +286,7 @@
                struct ieee80211_node_table *, const u_int8_t macaddr[]);
 void   ieee80211_node_join(struct ieee80211com *, struct ieee80211_node *,int);
 void   ieee80211_node_leave(struct ieee80211com *, struct ieee80211_node *);
-u_int8_t ieee80211_getrssi(struct ieee80211com *ic);
+int8_t ieee80211_getrssi(struct ieee80211com *ic);
 
 /*
  * Parameters supplied when adding/updating an entry in a
diff -r 7c7b8d6da890 -r 117815f3753d sys/net80211/ieee80211_rssadapt.h
--- a/sys/net80211/ieee80211_rssadapt.h Wed Apr 06 11:07:58 2016 +0000
+++ b/sys/net80211/ieee80211_rssadapt.h Wed Apr 06 14:42:16 2016 +0000
@@ -1,4 +1,4 @@
-/* $NetBSD: ieee80211_rssadapt.h,v 1.7 2009/10/19 23:19:39 rmind Exp $ */
+/* $NetBSD: ieee80211_rssadapt.h,v 1.8 2016/04/06 14:42:16 roy Exp $ */
 /*-
  * Copyright (c) 2003, 2004 David Young.  All rights reserved.
  *
@@ -79,7 +79,7 @@
        u_int                    id_len;        /* Tx packet length */
        u_int                    id_rateidx;    /* index into ni->ni_rates */
        struct ieee80211_node   *id_node;       /* destination STA MAC */
-       u_int8_t                 id_rssi;       /* destination STA avg RSS @
+       int8_t                   id_rssi;       /* destination STA avg RSS @
                                                 * Tx time
                                                 */
 };
diff -r 7c7b8d6da890 -r 117815f3753d sys/net80211/ieee80211_var.h
--- a/sys/net80211/ieee80211_var.h      Wed Apr 06 11:07:58 2016 +0000
+++ b/sys/net80211/ieee80211_var.h      Wed Apr 06 14:42:16 2016 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: ieee80211_var.h,v 1.28 2010/01/17 19:45:07 pooka Exp $ */
+/*     $NetBSD: ieee80211_var.h,v 1.29 2016/04/06 14:42:16 roy Exp $   */
 /*-
  * Copyright (c) 2001 Atsushi Onoe
  * Copyright (c) 2002-2005 Sam Leffler, Errno Consulting
@@ -156,7 +156,7 @@
        struct ieee80211_node   *(*ic_node_alloc)(struct ieee80211_node_table*);
        void                    (*ic_node_free)(struct ieee80211_node *);
        void                    (*ic_node_cleanup)(struct ieee80211_node *);
-       u_int8_t                (*ic_node_getrssi)(const struct ieee80211_node*);
+       int8_t                  (*ic_node_getrssi)(const struct ieee80211_node*);
        u_int16_t               ic_lintval;     /* listen interval */
        u_int16_t               ic_bintval;     /* beacon interval */
        u_int16_t               ic_holdover;    /* PM hold over duration */



Home | Main Index | Thread Index | Old Index