Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/common/lib/libc/misc Tidy up the comment in ubsan.c



details:   https://anonhg.NetBSD.org/src/rev/cbd4cdedfa9b
branches:  trunk
changeset: 834237:cbd4cdedfa9b
user:      kamil <kamil%NetBSD.org@localhost>
date:      Fri Aug 03 03:12:32 2018 +0000

description:
Tidy up the comment in ubsan.c

As noted, style has no impact on the comparison of a similar code.
This version is a reimplementation from scratch with no code and no
algirithm (whenever possible) reuse.

Public symbols and struct layout must be kept in sync with the code
generation part. It casues violation of the style like with long filenames.

My previous comment was 'too perfect' and could trigger some unnecessary
attention.

diffstat:

 common/lib/libc/misc/ubsan.c |  12 +++++-------
 1 files changed, 5 insertions(+), 7 deletions(-)

diffs (31 lines):

diff -r 623554442ec6 -r cbd4cdedfa9b common/lib/libc/misc/ubsan.c
--- a/common/lib/libc/misc/ubsan.c      Fri Aug 03 02:34:31 2018 +0000
+++ b/common/lib/libc/misc/ubsan.c      Fri Aug 03 03:12:32 2018 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: ubsan.c,v 1.1 2018/08/03 02:05:43 kamil Exp $  */
+/*     $NetBSD: ubsan.c,v 1.2 2018/08/03 03:12:32 kamil Exp $  */
 
 /*-
  * Copyright (c) 2018 The NetBSD Foundation, Inc.
@@ -32,17 +32,15 @@
  * The uBSSan versions is suitable for inclusion into libc or used standalone
  * with ATF tests.
  *
- * This file due to long symbol names and licensing reasons does not fully
- * follow the KNF style with 80-column limit. Hungarian style variables
- * and function names are on the same purpose (Pascal and Snake style names,
- * are used in different implementations).
+ * This file due to long symbol names generated by a compiler during the
+ * instrumentation process does not follow the KNF style with 80-column limit.
  */
 
 #include <sys/cdefs.h>
 #if defined(_KERNEL)
-__KERNEL_RCSID(0, "$NetBSD: ubsan.c,v 1.1 2018/08/03 02:05:43 kamil Exp $");
+__KERNEL_RCSID(0, "$NetBSD: ubsan.c,v 1.2 2018/08/03 03:12:32 kamil Exp $");
 #else
-__RCSID("$NetBSD: ubsan.c,v 1.1 2018/08/03 02:05:43 kamil Exp $");
+__RCSID("$NetBSD: ubsan.c,v 1.2 2018/08/03 03:12:32 kamil Exp $");
 #endif
 
 #if defined(_KERNEL)



Home | Main Index | Thread Index | Old Index