Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/lib/libc/rpc PR/13082: Thorsten Brehm: Fix wrong memcpy that...



details:   https://anonhg.NetBSD.org/src/rev/517b888049eb
branches:  trunk
changeset: 785141:517b888049eb
user:      christos <christos%NetBSD.org@localhost>
date:      Tue Feb 26 16:33:57 2013 +0000

description:
PR/13082: Thorsten Brehm: Fix wrong memcpy that caused possible memory
corruption. XXX: pullup to 6.

diffstat:

 lib/libc/rpc/clnt_vc.c |  8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diffs (29 lines):

diff -r b4a0eac4ba04 -r 517b888049eb lib/libc/rpc/clnt_vc.c
--- a/lib/libc/rpc/clnt_vc.c    Tue Feb 26 15:23:19 2013 +0000
+++ b/lib/libc/rpc/clnt_vc.c    Tue Feb 26 16:33:57 2013 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: clnt_vc.c,v 1.18 2012/03/13 21:13:44 christos Exp $    */
+/*     $NetBSD: clnt_vc.c,v 1.19 2013/02/26 16:33:57 christos Exp $    */
 
 /*
  * Sun RPC is a product of Sun Microsystems, Inc. and is provided for
@@ -36,7 +36,7 @@
 static char *sccsid = "@(#)clnt_tcp.c  2.2 88/08/01 4.0 RPCSRC";
 static char sccsid[] = "@(#)clnt_vc.c 1.19 89/03/16 Copyr 1988 Sun Micro";
 #else
-__RCSID("$NetBSD: clnt_vc.c,v 1.18 2012/03/13 21:13:44 christos Exp $");
+__RCSID("$NetBSD: clnt_vc.c,v 1.19 2013/02/26 16:33:57 christos Exp $");
 #endif
 #endif
  
@@ -263,8 +263,8 @@
        ct->ct_addr.buf = malloc((size_t)raddr->maxlen);
        if (ct->ct_addr.buf == NULL)
                goto fooy;
-       memcpy(ct->ct_addr.buf, &raddr->buf, (size_t)raddr->len);
-       ct->ct_addr.len = raddr->maxlen;
+       memcpy(ct->ct_addr.buf, raddr->buf, (size_t)raddr->len);
+       ct->ct_addr.len = raddr->len;
        ct->ct_addr.maxlen = raddr->maxlen;
 
        /*



Home | Main Index | Thread Index | Old Index