Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/netbsd-8]: src/sys/kern Pull up following revision(s) (requested by maxv...



details:   https://anonhg.NetBSD.org/src/rev/41f6fb3aa45c
branches:  netbsd-8
changeset: 852142:41f6fb3aa45c
user:      martin <martin%NetBSD.org@localhost>
date:      Thu Nov 29 14:58:25 2018 +0000

description:
Pull up following revision(s) (requested by maxv in ticket #1112):

        sys/kern/sys_ptrace_common.c: revision 1.46

Fix stack info leak.

        + Possible info leak: [len=136, leaked=92]
        | #0 0xffffffff80baf397 in kleak_copyout
        | #1 0xffffffff80bd4155 in ptrace_copyout_siginfo
        | #2 0xffffffff80bd5348 in do_ptrace
        | #3 0xffffffff80bd40fe in sys_ptrace
        | #4 0xffffffff80259c42 in syscall

diffstat:

 sys/kern/sys_ptrace_common.c |  5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diffs (26 lines):

diff -r 50daeef20036 -r 41f6fb3aa45c sys/kern/sys_ptrace_common.c
--- a/sys/kern/sys_ptrace_common.c      Thu Nov 29 08:52:08 2018 +0000
+++ b/sys/kern/sys_ptrace_common.c      Thu Nov 29 14:58:25 2018 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: sys_ptrace_common.c,v 1.22.2.3 2018/05/05 19:13:21 martin Exp $        */
+/*     $NetBSD: sys_ptrace_common.c,v 1.22.2.4 2018/11/29 14:58:25 martin Exp $        */
 
 /*-
  * Copyright (c) 2008, 2009 The NetBSD Foundation, Inc.
@@ -118,7 +118,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: sys_ptrace_common.c,v 1.22.2.3 2018/05/05 19:13:21 martin Exp $");
+__KERNEL_RCSID(0, "$NetBSD: sys_ptrace_common.c,v 1.22.2.4 2018/11/29 14:58:25 martin Exp $");
 
 #ifdef _KERNEL_OPT
 #include "opt_ptrace.h"
@@ -553,6 +553,7 @@
 {
        struct ptrace_siginfo psi;
 
+       memset(&psi, 0, sizeof(psi));
        psi.psi_siginfo._info = t->p_sigctx.ps_info;
        psi.psi_lwpid = t->p_sigctx.ps_lwp;
 



Home | Main Index | Thread Index | Old Index