[src/trunk]: src/sys/dev/ic no need to clear DMA WAIT flag in mvsata_edma_han...

[jdolecek <jdolecek%NetBSD.org@localhost>]

details:   https://anonhg.NetBSD.org/src/rev/0ac39e42893c
branches:  trunk
changeset: 827164:0ac39e42893c
user:      jdolecek <jdolecek%NetBSD.org@localhost>
date:      Tue Oct 17 16:24:14 2017 +0000

description:
no need to clear DMA WAIT flag in mvsata_edma_handle(), it's not needed
by atabus layer

diffstat:

 sys/dev/ic/mvsata.c |  19 +++----------------
 1 files changed, 3 insertions(+), 16 deletions(-)

diffs (54 lines):

diff -r 6d25307c1c5e -r 0ac39e42893c sys/dev/ic/mvsata.c
--- a/sys/dev/ic/mvsata.c       Tue Oct 17 16:23:50 2017 +0000
+++ b/sys/dev/ic/mvsata.c       Tue Oct 17 16:24:14 2017 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: mvsata.c,v 1.38 2017/10/10 16:30:23 jdolecek Exp $     */
+/*     $NetBSD: mvsata.c,v 1.39 2017/10/17 16:24:14 jdolecek Exp $     */
 /*
  * Copyright (c) 2008 KIYOHARA Takashi
  * All rights reserved.
@@ -26,7 +26,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: mvsata.c,v 1.38 2017/10/10 16:30:23 jdolecek Exp $");
+__KERNEL_RCSID(0, "$NetBSD: mvsata.c,v 1.39 2017/10/17 16:24:14 jdolecek Exp $");
 
 #include "opt_mvsata.h"
 
@@ -2829,7 +2829,7 @@
        struct ata_bio *ata_bio;
        struct ata_xfer *xfer;
        uint32_t reg;
-       int erqqip, erqqop, erpqip, erpqop, prev_erpqop, quetag, handled = 0, n;
+       int erqqop, erpqip, erpqop, prev_erpqop, quetag, handled = 0, n;
        int st, dmaerr;
 
        /* First, Sync for Request Queue buffer */
@@ -2920,12 +2920,6 @@
 
                mvsata_dma_bufunload(mvport, quetag, ata_bio->flags);
 
-#if 1  /* XXXX: flags clears here, because necessary the atabus layer. */
-               erqqip = (MVSATA_EDMA_READ_4(mvport, EDMA_REQQIP) &
-                   EDMA_REQQP_ERQQP_MASK) >> EDMA_REQQP_ERQQP_SHIFT;
-               if (erpqop == erqqip)
-                       chp->ch_flags &= ~(ATACH_DMA_WAIT);
-#endif
                mvsata_bio_intr(chp, xfer, 1);
                if (xfer1 == NULL)
                        handled++;
@@ -2952,13 +2946,6 @@
        reg |= (erpqop << EDMA_RESQP_ERPQP_SHIFT);
        MVSATA_EDMA_WRITE_4(mvport, EDMA_RESQOP, reg);
 
-#if 0  /* already cleared ago? */
-       erqqip = (MVSATA_EDMA_READ_4(mvport, EDMA_REQQIP) &
-           EDMA_REQQP_ERQQP_MASK) >> EDMA_REQQP_ERQQP_SHIFT;
-       if (erpqop == erqqip)
-               chp->ch_flags &= ~(ATACH_DMA_WAIT);
-#endif
-
        return handled;
 }